Gadgetbridge icon indicating copy to clipboard operation
Gadgetbridge copied to clipboard

Add device s200

Open albertsal opened this issue 7 years ago • 11 comments

I added the s200 sport device management similar to the MAKIBESF68 ..

I modified the showIncomingCall logic, showText, encodeStringToDevice.

The device works in unicode but for incoming calls is mixed

albertsal avatar Jul 11 '17 20:07 albertsal

Thanks!

Can you please remove all the formatting changes? Whitespaces and tabs.

Also please do the same indention as we do (default Android Studio)

ashimokawa avatar Jul 11 '17 20:07 ashimokawa

@ashimokawa sorry ... i use project settings ... can you tell me the parameters to set?

albertsal avatar Jul 11 '17 21:07 albertsal

I prefer having different classes overriding the default behaviour whenever necessary. Especially in this case where the number of different devices may be large.

The rest of the code seems to be ok.

jpbarraca avatar Jul 14 '17 13:07 jpbarraca

@jpbarraca Welcome back ;) Do you want to merge this and then change the code according to your taste?

About the indention, it would be cool if you could use the same style as android studio default which we are using to prevent unrelated formatting changes from happening.

ashimokawa avatar Jul 14 '17 14:07 ashimokawa

@albertsal How can we distinguish the S200 from the other HPLUS devices?

jpbarraca avatar Jul 17 '17 21:07 jpbarraca

As for the MAKIBESF68 also s200 starts with SPORT

albertsal avatar Jul 18 '17 05:07 albertsal

Is there an additional message supported? or a characteristic? If nothing is available we will have to resort to a configuration option.

What is the hardware and firmware versions?

jpbarraca avatar Jul 18 '17 16:07 jpbarraca

I attach the information I get

88820170718_222740 gadgetbridge.txt

albertsal avatar Jul 18 '17 20:07 albertsal

I find it odd that this is required (mixed language support). Also I find not accurate method to identify the device type. What is the problem that you find with the current version? Also, can you please try this version ?

jpbarraca avatar Jul 19 '17 22:07 jpbarraca

For messages it requires unicode but for calls if I use unicode he writes in chinese Ok I try your version

albertsal avatar Jul 20 '17 05:07 albertsal

When I receive a message, the message is displayed with spaces .... I have solved this problem by applying the first 2 bytes characteristic of the unicode only at the beginning of the message the remaining characters apply only the final 0 .... do Reference to my code ...

Regarding Chinese call visualization calls (this problem is also visible with hplus) I have solved not using unicode for this function

I forgot s200 does not support concatenated messages so I set a maximum number of characters to use all the space ... I also inserted small optimizations like truncating the message object to use the best available space

albertsal avatar Jul 20 '17 06:07 albertsal