meta-freescale icon indicating copy to clipboard operation
meta-freescale copied to clipboard

vulkan-loader: Remove .so in main package

Open chrisdimich opened this issue 3 years ago • 5 comments

Doing this causes a build failure in imx-gpu-sdk (meta-freescale-distro layer of BSP)

ERROR: imx-gpu-sdk-5.7.1-r0 do_package_qa: QA Issue: imx-gpu-sdk rdepends on vulkan-loader-dev [dev-deps] ERROR: imx-gpu-sdk-5.7.1-r0 do_package_qa: Fatal QA errors were found, failing task. ERROR: Logfile of failure stored in: /backup/jenkins/jobs/yocto_kirkstone/workspace/build-boundary-xwayland-nitrogen8mp/tmp/work/cortexa53-mx8mp-fslc-linux/imx-gpu-sdk/5.7.1-r0/temp/log.do_package_qa.820 ERROR: Task (/backup/jenkins/jobs/yocto_kirkstone/workspace/sources/meta-freescale-distro/recipes-graphics/imx-gpu-sdk/imx-gpu-sdk_5.7.1.bb:do_package_qa) failed with exit code '1'

This is a revert of the following commit:

https://github.com/Freescale/meta-freescale/commit/8648cedaa35519cad859207e25689889155760a9

chrisdimich avatar Oct 14 '22 18:10 chrisdimich

Is this better handled with an INSANE_SKIP?

On the other hand, the premise of the original commit is that the .so is what is dynamically loaded. Is this correct, or is it more reasonable to expect the load to use SONAME?

thochstein avatar Oct 14 '22 18:10 thochstein

Honestly, whatever you think is best as long as the BSP can build :)

chrisdimich avatar Oct 14 '22 18:10 chrisdimich

I'm not sure, I think we did this to get our runtime working, but maybe we could have fixed our runtime by dynamically loading SONAME.

@otavio, what is your opinion?

thochstein avatar Oct 14 '22 18:10 thochstein

Oh, also, it looks like there is a newer version of imx-gpu-sdk that needs to be upstreamed. That might fix the problem as well. I'll work on this later today.

thochstein avatar Oct 14 '22 18:10 thochstein

The new version doesn't fix the issue.

@chrisdimich, can you see if #1271 fixes your problem?

thochstein avatar Oct 15 '22 18:10 thochstein

Fixed in #1271

otavio avatar Oct 20 '22 15:10 otavio