wordpress-sdk icon indicating copy to clipboard operation
wordpress-sdk copied to clipboard

PHP8.4 alpha 1 warnings - nullable is deprecated, the explicit nullable type must be used instead

Open ipajen opened this issue 1 year ago • 1 comments

🐞 bug report

Behavior:

  • What is the issue? (*)
PHP 8.4alpha1 contains PHP warnings
  • What is the expected behavior?
No warnings

Versions: (*)

  • Freemius SDK Version: 2.7.2
  • WordPress Version: 6.6
  • PHP Version: 8.4alpha1

`PHP Deprecated: Freemius::maybe_activate_bundle_license(): Implicitly marking parameter $license as nullable is deprecated, the explicit nullable type must be used instead in C:\wamp64\www\wp\wp-content\plugins\wp-review-slider-pro\freemius\includes\class-freemius.php on line 8038

PHP Deprecated: Freemius::set_license(): Implicitly marking parameter $license as nullable is deprecated, the explicit nullable type must be used instead in C:\wamp64\www\wp\wp-content\plugins\wp-review-slider-pro\freemius\includes\class-freemius.php on line 12666

PHP Deprecated: Freemius::switch_to_blog(): Implicitly marking parameter $install as nullable is deprecated, the explicit nullable type must be used instead in C:\wamp64\www\wp\wp-content\plugins\wp-review-slider-pro\freemius\includes\class-freemius.php on line 15893

PHP Deprecated: Freemius::_activate_addon_account(): Implicitly marking parameter $bundle_license as nullable is deprecated, the explicit nullable type must be used instead in C:\wamp64\www\wp\wp-content\plugins\wp-review-slider-pro\freemius\includes\class-freemius.php on line 18365

PHP Deprecated: Freemius::_store_site(): Implicitly marking parameter $site as nullable is deprecated, the explicit nullable type must be used instead in C:\wamp64\www\wp\wp-content\plugins\wp-review-slider-pro\freemius\includes\class-freemius.php on line 19923`


Note: (*) indicates required information. Without this information, your issue may be auto-closed.

You can find your Freemius SDK version at /freemius/start.php

You can find your Freemius product ID in the Freemius dashboard: SETTINGS -> INTEGRATION.

Do not modify the titles or questions. Simply add your responses to the ends of the questions. Add more lines if needed.

ipajen avatar Jul 17 '24 12:07 ipajen

https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

ipajen avatar Jul 17 '24 12:07 ipajen

One of our customers just reported the same.

Image

Would be great to get this issue fixed asap. Especially because it's open since 2024/07 already.

flowdee avatar Feb 21 '25 08:02 flowdee

hi, we've started testing our plugin with 8.4.5, and we now notice these warnings too.

Image

LC43 avatar Mar 24 '25 14:03 LC43

almost a year for such an easy fix. as a developer I see it every day, multiple times a day and it's jarring.

LC43 avatar Apr 08 '25 06:04 LC43

@vovafeldman @swashata 👀

flowdee avatar Apr 25 '25 09:04 flowdee

@flowdee , @LC43 sorry for the delay. We are going to fix it in the coming release (tentative coming Sunday)

swashata avatar May 01 '25 07:05 swashata

Issue has been fixed https://github.com/Freemius/wordpress-sdk/releases/tag/2.12.0

swashata avatar May 11 '25 07:05 swashata