wordpress-sdk icon indicating copy to clipboard operation
wordpress-sdk copied to clipboard

Polylang conflict

Open Stibo opened this issue 4 years ago • 4 comments

🐞 bug report

Behavior:

  • What is the issue? (*) If polylang is installed, the following text appears on top of the plugin pages (the page with "Account", "Contact Us", "Upgrade" etc.): pll_ajax_backend=1&. I've digged a little bit into the code and discovered, that the issue is caused by the Polylang footer scripts. The reason I post this here and not directly to the Polylang support is, that Polylang isnt really doing anything wrong. I think the problem is caused by the way the Freemius SDK processes the backend output for those pages. This is one of the the lines in Polylang that may causes the problem:

options.data = '<?php echo $str; // phpcs:ignore WordPress.Security.EscapeOutput ?>&'+options.data;

As you can see, there are php opening and closing tags in a string, that will be outputted by Polylang later. I think this php tags in string will somehow break this code after its being processed by the Freemius SDK.

I hope this input helps to fix this problem, its really ugly to see pll_ajax_backend=1& on this pages.

  • What is the expected behavior? The expected behaviour is, that text does not appear on those pages.

Versions: (*)

  • Freemius SDK Version: 2.3.2
  • WordPress Version: 5.4.1
  • PHP Version: 7.3

Stibo avatar Jun 09 '20 10:06 Stibo

This is still an issue with the current version. Any response from you guys would be appreciated!

Stibo avatar Sep 17 '20 09:09 Stibo

Do you guy even read the issues on GitHub? This is still an issue.

Stibo avatar Apr 13 '21 11:04 Stibo

Hi @Stibo and thanks for your report! Sorry for not commenting earlier, we are definitely reviewing issues on GitHub. This never got prioritized as you are the only one who raised the issue in over 5 years, and we never saw it happening with any other plugins setup. I wish we could do everything, but we have to prioritize our resources. Regardless, if you already have the environment in place it would be great if you could upload a screenshot of the issue so we'll have it recorded for when we get to it.

vovafeldman avatar Apr 13 '21 12:04 vovafeldman

Hi, thanks for the answer. It actually happens on every page that has the plugin "Polylang" installed.

Stibo avatar May 03 '21 08:05 Stibo