wordpress-sdk icon indicating copy to clipboard operation
wordpress-sdk copied to clipboard

[theme] Handling of the case when a child theme's parent is a free th…

Open fajardoleo opened this issue 5 years ago • 2 comments

…eme version but the installed theme is the premium one (cache manipulation).

fajardoleo avatar Oct 11 '18 16:10 fajardoleo

Judging from pure logic, not from testing in code:

Do I see that right, that in the end this code should be executed in the parent-theme? But the parent theme is not loaded, while the child theme is looking for the parent. So this class/action should never be fired.

Does that make sense?

Luehrsen avatar Oct 12 '18 08:10 Luehrsen

Alright. This code snippet works* and we are currently shipping it with our theme.

Works is relative here, because if you do not have the parent theme active (but the -premium version installed), the child theme will be shown to have no parent theme. This might throw off some users, but that is certainly catchable in support.

Luehrsen avatar May 28 '19 09:05 Luehrsen