Dean Galvin
Dean Galvin
Yup! I think until we decide on a "Best Practices" or start implementing true cache specific code it might be best to leave the expiry up to the user. That...
Good callout! I can't get in contact with @artob to setup a CI/CD pipeline to automate this unfortunately. Ill manually push an update out (as well as a tagged release)....
Right, I believe the block implementation would be best, but I am looking into other options that might be more straightforward :)
Are you requiring it anywhere: `require 'rack/throttle'` ?
Thanks for the first PR! Question, would `rack-attack` work for your use case instead? I have a PR open to deprecate in favor of it.
Ah! We are not currently adding additional functionality to rack-throttle as rack-attack is more full featured and better supported. My fear of adding this is anyone that relies on multiple...
If by chance there two requests do come in at the same time (in a concurrent app) it is possible for them to both read the value of the current...
Right, unfortunately this would require some cache-specific code. Though it could be "stubbed" out for a more generic get/set and allowed to be over-ridden via cache specific code.
@TheWudu I would be interested to hear your thoughts on this. Since that project has much more activity I think it may be worth deprecating this in favor of that...
It also has a really graceful/elegant way to handle the path based rules like you have implemented!