dory icon indicating copy to clipboard operation
dory copied to clipboard

Non-zero exit code on status if dory isn't totally "up"

Open ryanmt opened this issue 7 years ago • 4 comments

Alias ps=>status for docker-like behavior hidden in here as well.

I welcome feedback on the error code pattern. I wanted to make it a "means the number of services down" but figured it didn't actually matter as long as it was easier to script against, for my purposes.

ryanmt avatar Sep 25 '17 19:09 ryanmt

Ah, specs! I'll go poke at those and testing the exit codes, also track if there's some value in delaying the exit as well.

ryanmt avatar Sep 25 '17 20:09 ryanmt

Nice, thanks man! I like it.

I can take a look at the spec in more detail tomorrow. I just glanced at it and it seems like the spec may just need to be updated for the new exit status, tho I'm not 100% sure on that yet.

FreedomBen avatar Sep 26 '17 05:09 FreedomBen

Yo @ryanmt , you still want to merge this? I totally spaced it and randomly remembered. I looked at the test failure and it's not a big deal. I can refactor it to accommodate the new exit status. Sorry it took freaking forever. Is this still useful?

FreedomBen avatar Jul 25 '18 03:07 FreedomBen

I think this could be useful, @FreedomBen.

tripox avatar Apr 20 '21 16:04 tripox