preserve fzf-flags zstyle
With this line included, fzf-tab fzf-flags options are overwritten.
And I don't see how --preview-window=+0 is needed, as its the default value anyway.
This was a real source of annoyance for me https://github.com/Freed-Wu/fzf-tab-source/issues/27#issuecomment-2930326831 as well as wondering why my fzf-tab --color configuration wasn't working.
Summary by CodeRabbit
- Refactor
- Removed the assignment of default or custom flags for the fuzzy finder interface, resulting in no flags being set by default in this area.
Walkthrough
The code change removes the assignment of fzf-flags style for each context in the fzf-tab-source.plugin.zsh file. The logic that previously set fzf-flags to extracted or default values has been deleted, so no flags are set in this section now.
Changes
| File(s) | Change Summary |
|---|---|
| fzf-tab-source.plugin.zsh | Removed assignment of fzf-flags style for each context. |
Poem
A flag once set, now hops away,
No previews left to guide the way.
The code is lighter, context clear,
The tabbing magic still is near.
With every shell, a breezy breezeβ
The rabbit smiles at changes, pleased!
πβ¨
π Recent review details
Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro
π₯ Commits
Reviewing files that changed from the base of the PR and between a06c2cf1f9b4f1582cb7536ce06f12ba02696ea6 and a2178f8d1d32c24e4d9fa812cad56d36983981c2.
π Files selected for processing (1)
fzf-tab-source.plugin.zsh(0 hunks)
π€ Files with no reviewable changes (1)
- fzf-tab-source.plugin.zsh
β¨ Finishing Touches
- [ ] π Generate Docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
πͺ§ Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>, please review it.Explain this complex logic.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai explain this code block.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.@coderabbitai read src/utils.ts and explain its main purpose.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.@coderabbitai help me debug CodeRabbit configuration file.
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai generate docstringsto generate docstrings for this PR.@coderabbitai generate sequence diagramto generate a sequence diagram of the changes in this PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.