FreeTubeApp
Search Box - Long query
Behavior of the program After entering to Search Box a long query error messages are displayed.
Expected behavior No results and no error messages. Probably the length of a search-query should be limited.
To Reproduce
- Paste to a search box long query (we've tested with 150k symbols query, which is attached below)
- Press Enter
- See error messages
Screenshots
Environment Information:
- OS: Windows
- OS Version: Windows 10
- FreeTube version: 0.11.1
- Installation Method (If applicable): .exe
- Primary API Used: [Local API, Invidious API]
Additional context Our team (@Vovany4, @kgr0) has experienced this bug.
This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@absidue i imagine you've started work on using youtube.js for search, do you know if this will still be an issue once we migrate to that library?
You won't see an error with the local API after the migration, there just won't be any results.
The code is done apart from child friendly search, which I opened a feature request for https://github.com/LuanRT/YouTube.js/issues/266), other than that it's ready for PRing.
This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.
IV still craps itself but the Local API is just loading forever now without throwing an error
https://github.com/FreeTubeApp/FreeTube/assets/73130443/bc4afd7e-3c13-4f64-9461-9cd44dfbdc23
This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This is happening because there is a limit for the number of characters a query can have.
Current limit according to my tests are: 100 Characters
I have a fix but its not mergeable. I might need someone's help who knows the codebase a bit to fix this issue.
This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.
@dkshxd go for it :)
Edit: learn from past PR issues https://github.com/FreeTubeApp/FreeTube/pull/4288