replace SideNav 'closed' class to 'open'

[AndreJesusBrito]

Pull Request Type

• [X] Bugfix
• [ ] Feature Implementation
• [ ] Documentation
• [x] Other

Related issue

closes #6091

Description

This pull request is mostly a refactor and doesn't have any visual or functional effect besides fixing the mentioned issue.

The 'open' state now becomes the default for styling. This has three advantages:

• This makes it consistent with the rest of the application logic (isOpen)
• Simplifies styling. The open styles can now be done for desktop easily with a media query
• Fixes #6091 [Bug]: Theme Settings > Expand side bar by default is affecting the bottom navigation for mobile devices

Testing

Ensure that the interface behaves as before when the app resolution (media queries), nav bar open toggle and the Theme > Hide Side Bar Labels option vary.

Desktop

• OS: Arch Linux
• OS Version: N/A
• FreeTube version: v0.23.12-beta

[github-actions[bot]]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions[bot]]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[AndreJesusBrito]

@absidue I have checked and it's working correctly, the only thing I have to change is remove the margin at the right

RTL locale:

LTR locale with margin:

LTR locale without margin:

I have also rebased my patch on top of the current development branch

[absidue]

Feel free to change whatever you need to change to make it look and work the same (on all screen sizes) as it did before this PR, as the pull request description says that there shouldn't be any visual changes.