Fix cross channel videos link sometimes broken
Pull Request Type
- [x] Bugfix
- [ ] Feature Implementation
- [ ] Documentation
- [ ] Other
Related issue
Description
There are some cross channel (cross 2 channels) videos and sometimes the handling is faulty (already handled sometimes)
Like having channel links with channel ID like N/A or empty string and if you click it you see no such channel message
This PR fixes those missing places
Screenshots
Testing
Local API + IV API
- Search for
Moore's Law Is Dead and Ancient Gameplays, Look forNvidia RTX 5080 SUPER Cancelled? AMD RX 9080 XT & RDNA 5 🧐 | Ancient Gameplays | Broken Silicon 335, ensure no channel link (no way to infer) - Add that video to a user playlist, ensure no link shown in playlist
- Visit the channel https://www.youtube.com/channel/UCRPdsCVuH53rcbTcEkuY4uQ (one of the channels of above video), ensures above video shown with link (back to the same page)
- Subscribe the channel and refresh sub, ensure above video shown with link to channel page
Desktop
- OS:
- OS Version:
- FreeTube version:
Additional context
IV got no channel link for those videos which might or might not be improved in this PR (not a.t.m. of writing) Update 1: Fixed IV API to be the same as local API
Im a bit confused about this PR. What does it solve? Maybe add before and after screenshots so my Magikarp brain understands
Oh before fix you see links with channel ID like N/A or empty string and if you click it you see no such channel message
Added to description
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.