FreeTube icon indicating copy to clipboard operation
FreeTube copied to clipboard

[Bug]: Clicking outside the search bar does not close search suggestions/history

Open Du4lity5151 opened this issue 7 months ago • 14 comments

Guidelines

Describe the bug

  1. Type in a search query and/or click on one of the search suggestions/previous searches
  2. Backspace through search query (without clicking 'x')
  3. Attempt to get the search suggestions to stop showing by clicking the 'x' or clicking outside of the search bar
  4. (Optional) Click on various parts of the search bar (just above or below it but in between the first search suggestion or the 'x', etc.) an unknown/arbitrary amount of times before it finally stops showing
Image

Expected Behavior

If I backspace through the search query to get rid of it and then click off of the search bar, it should stop showing search suggestions.

Issue Labels

usability issue, visual bug

FreeTube Version

v0.23.5 Beta, still present in Build 6285: Commit 3d5dae5

Operating System Version

Windows 11 24H2

Installation Method

.exe

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

Can't remember

Additional Information

This does not seem to be an issue if clicking 'x' in step 3, but many users (including me) may have a habit of backspacing through the search query instead of clicking 'x'.

Nightly Build

Du4lity5151 avatar Aug 02 '25 10:08 Du4lity5151

What you are claiming to be a bug is an intentional feature. That is your search history (stored on your device, like all of your other FreeTube user data) not a search suggestion from YouTube (notice the different icon on the left side of it and the remove icon on the right side). If you don't want FreeTube to save and suggest your search history you can turn it off and clear it in the Privacy settings.

absidue avatar Aug 02 '25 10:08 absidue

What you are claiming to be a bug is an intentional feature. That is your search history (stored on your device, like all of your other FreeTube user data) not a search suggestion from YouTube (notice the different icon on the left side of it and the remove icon on the right side). If you don't want FreeTube to save and suggest your search history you can turn it off and clear it in the Privacy settings.

This is not what I was saying to be a bug. I meant that the search history would stay open, blocking the view of the video or search results, not that the bug was the fact it saves searches to show in place of search suggestions. I included the image to specify the UI element that was problematic. I apologize if that image was misleading.

Du4lity5151 avatar Aug 02 '25 20:08 Du4lity5151

@Du4lity5151 could you maybe share a video

Still sounds like it is working as designed.

While there is text in the search box it will show matches from your search history + YouTube search suggestions, when the box is empty but your cursor/focus is inside the search box it will show you your most recent searches, so that you can get back to them easily. If you move the focus outside of the search box, by clicking on other things outside of it or using the TAB key to move outside of it, the recent search history entries will disappear.

absidue avatar Aug 03 '25 10:08 absidue

Still sounds like it is working as designed.

While there is text in the search box it will show matches from your search history + YouTube search suggestions, when the box is empty but your cursor/focus is inside the search box it will show you your most recent searches, so that you can get back to them easily. If you move the focus outside of the search box, by clicking on other things outside of it or using the TAB key to move outside of it, the recent search history entries will disappear.

The issue is that "If you move the focus outside of the search box, by clicking on other things outside of it... ...the recent search history entries will disappear." specifically is not true when reproduced up to step 3.

Here is a video of the demonstration of the bug. Note that right after I backspace through the search, I attempt to close it by clicking off the search box. I then click on other tabs to show it still persists on displaying the search history. This time I tried to reproduce step 4 but could not get it to stop showing at the time. While pressing tab does work to make it disappear, some users may not be aware of this and may get frustrated with not being able to stop showing the search history.

Also, I recorded the video with an empty subscriptions and an artificially created search history for privacy reasons.

https://github.com/user-attachments/assets/d75df16d-53ed-4263-9bec-f2a91520b314

Du4lity5151 avatar Aug 03 '25 20:08 Du4lity5151

@Du4lity5151 thankyou for providing the video its much clearer to us now. Please try to capture step 4 also and share it when possible

@Du4lity5151 thankyou for providing the video its much clearer to us now. Please try to capture step 4 also and share it when possible

Here is my successful attempt at reproducing step 4. I initially struggled with the first search but after the second search in the video, I managed to get it to close.

https://github.com/user-attachments/assets/6ebf1250-d1e9-42e5-b84f-595fda0fd6c0

Du4lity5151 avatar Aug 03 '25 21:08 Du4lity5151

It also seems that when this happens, pressing tab usually does not work, and it only worked the one time I tested it.

Du4lity5151 avatar Aug 07 '25 21:08 Du4lity5151

@Du4lity5151 interesting could you maybe share a clip of that?

@Du4lity5151 interesting could you maybe share a clip of that?

In this visual example, tabbing does not close the search history but instead only selects other elements. I also updated to the most recent commit, Build 6317: Commit 3710b43 before recording this clip.

https://github.com/user-attachments/assets/02f37e8a-2fad-4694-b5e2-cf852b0ce7d2

Du4lity5151 avatar Aug 09 '25 20:08 Du4lity5151

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Sep 07 '25 02:09 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Oct 06 '25 02:10 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Nov 04 '25 02:11 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Dec 04 '25 02:12 github-actions[bot]