FreeTubeApp
feat: add option to hide the channel link
Pull Request Type
- [ ] Bugfix
- [x] Feature Implementation
- [ ] Documentation
- [ ] Other
Related issue
closes #3193
Description
This adds a option to the settings (parental controls) which allows the Channel Link to be hidden.
Screenshots
Testing
Open various videos, enable and disable the option
Desktop
- OS: Arch Linux
- FreeTube version: Newest Development branch (this commit)
Additional context
This was a requested feature (marked with good first issue) and I implemented it. I am new to contributing actual code to FreeTube. I have previously only contributed themes, so please let me know if anything should be done differently.
Also Hide Channel Link also hides unsubscribe button and I don't think that's expected just by reading that label
@PikachuEXE Yeah the name is definitely something which needs to be discussed. I previously also had "Hide Channel Actions" as the name, but because of the issue I changed it. I am not sure of what to call this.
any ideas for a better name @absidue @ChunkyProgrammer @kommunarr
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Apologies for the delay. Some suggestions i came up with:
- Limit Channel Discovery
- Restrict Channel Access
- Hide Channel Information
I feel the reason that its so hard to come up with a label is that it isnt clear where this is applied and to what elements. For example in our distraction free setting its clear what element is hidden and on what page it is applied
@PikachuEXE I would love to hear your opinion as well! (Since I am not sure of what to use (even with @efb4f5ff-1298-471a-8973-3d47447115dc's suggestions)). For me it would be the best if y'all could basically say "use X" and I just use that name :sweat_smile:
I think Restrict Channel Access is better but that would require this PR to have channel page to display "access restricted"...
We already have a setting to hide the subscribe button so maybe this setting can only hide the channel icon and name so we can name this setting properly?
@PikachuEXE For complexity's sake I would love to not do this 😛 @efb4f5ff-1298-471a-8973-3d47447115dc This sounds very smart since the subscribe part can be hidden. Implementing it.
This is how it looks now:
but I have one question: In the sidebar the channel name/icon is still visible (and clickable). Should this also be hidden?
but I have one question: In the sidebar the channel name/icon is still visible (and clickable). Should this also be hidden?
Thats seems highly out of scope of this PR tbh
@efb4f5ff-1298-471a-8973-3d47447115dc Yeah on one side I get what you are saying (and I would love not implementing it :D) but on the other side it is basically a "workaround" to still get to the channel page (which this is trying to prevent).
@DontBlameMe99
https://github.com/user-attachments/assets/19b08ffe-5421-44dd-83df-79fafed2e737
@efb4f5ff-1298-471a-8973-3d47447115dc Thanks for pointing this out! I completely missed that 😂
Hide uploader (optional word: details) on watch page
Credits to @absidue with coming up with this one
Implemented @efb4f5ff-1298-471a-8973-3d47447115dc.
Thanks absidue absidue for the good name!
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.
How do I even see linter warnings on GH... If "warnings" should be fixed they should be blocking PR
Please fix all the linter warnings.
Maintainers: maybe we should consider making all linter detections errors instead of warnings so that they block merging until they are fixed?
Hmm weird, we should definitely make it blocking
@PikachuEXE
https://github.com/user-attachments/assets/1aaf9ac4-6820-42a8-b6a8-90355808b7bb
Yeah definitely make them blocking! I did not even notice that they were there (because on my machine I didn't even see them), wasting your time.
@DontBlameMe99 Not sure what you use to do your commits on your computer but the linter runs in a pre-commit hook so you should see them in the output (they are definitely visible in the command line, but I'm not sure how GUI editors handle them). You should also see the yellow squiggles in your editor if you have Vue and ESLint integrations set up.
@absidue Thats weird. I am using nvim with the LSP (which might cause it to use a different formatting, I've noticed this sevaral times). But I am committing/pushing via lazygit/the git CLI, so this should definitely run them - but it doesn't. I'll have to look into this.