Allow unskipping of auto-skipped SponsorBlock segments

[0je]

Allow unskipping of auto-skipped SponsorBlock segments

via return key while toast is shown. Another return hit reskips the segment.

Similar to how it works on youtube.com or Invidious with SponsorBlock.

Pull Request Type

• [ ] Bugfix
• [x] Feature Implementation
• [ ] Documentation
• [ ] Other

Related issue

Relevant issues are: #6756 #1380 same problem, different suggestion #3116 PR that allowed seeking into otherwise auto-skipped segment, seems like it got lost with the move to the shaka video player.

Description

When a sponsor segment was auto-skipped, I sometimes want to unskip it for at least 2 reasons. The SponsorBlock segments are community provided and sometimes wrong/vandalism. Another reason are funny transitions that make me wonder what the ad is about. For now one would have to temporarily disable auto-skip / SponsorBlock and reload the video to watch the segment. This PR adds the option to unskip an auto-skipped segment by hitting the return key while the "segment skipped" toast is shown. Another return hit re-skips to the end of the segment.

[absidue]

#3116 PR that allowed seeking into otherwise auto-skipped segment, seems like it got lost with the move to the shaka video player.

It wasn't lost, it was intentionally removed. It didn't separate between the user manually seeking or SponsorBlock seeking, so it quite frequently didn't skip segments even though there was no indication from the user that they wanted to see the segment. Apart from randomly just not skipping it was also especially problematic for back-to-back segments as it would treat the seek for the skip from the first one as a reason to not skip the second one. Quoting the migration PR #4978:

I removed the ability to seek into sponsor block segments that are set to skip, as it was causing the skipping to not work properly, due to the existing implementation being fundamentally flawed. If someone would like to add something like that back in the future, it should require a specific user-interaction to unskip the segment, e.g. a button in the skip message, instead of allowing users to manually seek into the segment.

[efb4f5ff-1298-471a-8973-3d47447115dc]

Just to be clear there are 2 ways with SP to get into a segment:

• By letting the user literally click into the sponsor segment and nothing would happen
• By skipping the segment but giving the user the option to "unskip" it by going back to the beginning of the skipped segment and letting it play normally.

This PR implements the latter one.

[github-actions[bot]]

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[github-actions[bot]]

This PR was closed because it has been stalled for 14 days with no activity.