FreeTube icon indicating copy to clipboard operation
FreeTube copied to clipboard

Fix #4924 : Hide Search Bar and Filter in "Add to Playlist" When Playlists Are Less Than Two

Open anurag2787 opened this issue 9 months ago • 3 comments

Pull Request Type

  • [ ] Bugfix
  • [x] Feature Implementation
  • [ ] Documentation
  • [ ] Other

Related issue

closes #4924

Description

I have checked whether the playlist length is greater than two before displaying the search bar and search filter in the "Add to Playlist" section. This ensures that these elements will only appear when there are more than two playlists, improving UI clarity and user experience.

Additionally, I have applied the same fix to the Channel List and History pages, ensuring that the search bar will only appear when there is more than one channel or video. This keeps the interface clean and consistent across different sections.

Screenshots

Playlist Before

Screenshot 2025-03-22 132141

Playlist After

Screenshot 2025-03-22 131920

Channels Before

Screenshot 2025-03-22 160107

Channels After

Screenshot 2025-03-22 160126

History Before

Screenshot 2025-03-22 154706

History After

Screenshot 2025-03-22 154631

Desktop

  • OS: Windows 11
  • OS Version: 24H2 (OS Build 26100.3476)
  • FreeTube version: 0.23.2

Additional context

This update prevents unnecessary UI elements from appearing when there are fewer than two playlists, channels, or videos, making the interface cleaner and more intuitive across the "Add to Playlist," Channel List, and History pages.

anurag2787 avatar Mar 22 '25 08:03 anurag2787

@efb4f5ff-1298-471a-8973-3d47447115dc Please review it

anurag2787 avatar Mar 22 '25 10:03 anurag2787

I believe you misunderstood the problem. The problem is with the Add to playlist prompt: 2025-03-22-120559_hyprshot

MarmadileManteater avatar Mar 22 '25 16:03 MarmadileManteater

Thanks for the feedback, @MarmadileManteater ! I now understand that the issue is with the add to playlist prompt specifically. Would you prefer me to revert the earlier commit and apply the correct fix, or should I add another commit on top of the existing one to address the issue?

anurag2787 avatar Mar 23 '25 00:03 anurag2787

It does not matter. You could reset to a previous commit, or you could keep going. It will be squash merged either way. I typically prefer a continuous history of what happened.

MarmadileManteater avatar Mar 23 '25 13:03 MarmadileManteater

Hi @MarmadileManteater , Please Review . Thanks!

anurag2787 avatar Mar 23 '25 14:03 anurag2787