Fix: Utilize empty space for playlist queue when Hide Recommended Videos is enabled
Fix: Utilize empty space for playlist queue when Hide Recommended Videos is enabled
Pull Request Type
- [x] Bugfix
- [ ] Feature Implementation
- [ ] Documentation
- [ ] Other
Related issue
closes #6925
Description
Playlist area is expanded the entire height of the sidebar when recommended videos are disabled and viewport is wide enough.
Screenshots
Before:
After:
Additional context
Unsure if modifying the main viewport height or using @media selectors is the best way to go about this, but it's what I came up with and seems okay when tested with different viewport sizes.
To me areas not lining up is visually displeasing. Would prefer to see https://github.com/FreeTubeApp/FreeTube/issues/6925#issuecomment-2685139697
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.
This could be accomplished with pure CSS and :has selectors (by checking for .sidebarArea:has(.watchVideoRecommendations)). It is unnecessary to pull the setting value.
This could be accomplished with pure CSS and
:hasselectors (by checking for.sidebarArea:has(.watchVideoRecommendations)). It is unnecessary to pull the setting value.
That's a good point but I think the whole solution isn't very robust and probably the wrong way to go about it. Plus I haven't had any time to work on another solution.
That is valid. My recommendation, when you come back to it, would be to start over and just see if you can accomplish this without touching anything but css. If you don't have time right now, that is completely understandable. Life is busy.
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.
This PR was closed because it has been stalled for 14 days with no activity.