FreeTube icon indicating copy to clipboard operation
FreeTube copied to clipboard

Update Invidious DASH xtags handling for YouTube.js changes

Open absidue opened this issue 7 months ago • 0 comments

Update Invidious DASH xtags handling for YouTube.js changes

Pull Request Type

  • [x] Bugfix (well fixing a future bug once the change lands in a YouTube.js release)

Related issue

  • https://github.com/LuanRT/YouTube.js/pull/909

Description

In https://github.com/LuanRT/YouTube.js/pull/909 I switched YouTube.js from parsing the xtags from the URL query parameter to using the xtags property that contains a protobuf with the same information, to support SABR only responses that don't have the adaptive format URLs. As Invidious doesn't expose that property through their API (I don't have access to an Invidious instance with the API enabled but I checked their code), we need to keep the old behaviour of using the URL query parameter for our DASH manifest generation for Invidious.

The xtags contain information about the language and the audio content type of the audio track, as well as whether the audio track is stable volume one (DRC).

Testing

There are barely any public Invidious instances left and those that do exist have the API disabled, so I haven't actually been able to test this but as the code is the same as what YouTube.js used to do, I think it is probably fine 😅.

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: 68ec1e12bbdfa6b37122f9513ae1a5fc05ddb3e2

absidue avatar Feb 27 '25 21:02 absidue