Added a search button in the filter modal

[MilkyLane]

Title

This adds the feature "apply button to search filters modal"

Pull Request Type

• [ ] Bugfix
• [x] Feature Implementation
• [ ] Documentation
• [ ] Other

Related issue

#6194

Closes: #6194

Description

Added a new function that uses the same openInternnalPath function used by main search, a button, and a gap for the new button improvements. Tested functionality using console logs and trial-and-error. No known issues.

Screenshots

Testing

Pull request tested

Tested using console logs and trial-and-error to verify functionality.

No ramifications remaining

Desktop

• OS: Windows
• OS Version: 10, Version 22H2
• FreeTube version: v0.23.2 Beta

Additional context

No additional context.

[efb4f5ff-1298-471a-8973-3d47447115dc]

see review comments on https://github.com/FreeTubeApp/FreeTube/pull/6277 https://github.com/FreeTubeApp/FreeTube/pull/6627 to improve your PR

[MilkyLane]

see review comments on #6277 #6627 to improve your PR

I'm having trouble implementing the shift key functionality to open search results in a new window. The current implementation ive added detects the shift key press and tries to use ipcRenderer to send a 'createNewWindow' message (similar to how it's done in top-nav.vue) but it's not working. The normal search (without shift) works fine. Has anyone successfully implemented this behavior in other components? Any guidance would be much appreciated

[MilkyLane]

Updated PR has requested changes however i still could not get shift+click to open a new tab in the search filters view

[MarmadileManteater]

Updated PR has requested changes however i still could not get shift+click to open a new tab in the search filters view

The event parameter on the searchWithFilters function is being passed through as undefined.

[MarmadileManteater]

The reason it works on the ft-input is because of this line: https://github.com/FreeTubeApp/FreeTube/blob/d02e4f18be00e79fc39ca44c5265eab133b7ec27/src/renderer/components/ft-input/ft-input.js#L171

where the event is being passed through,

but on the ft-button

https://github.com/FreeTubeApp/FreeTube/blob/d02e4f18be00e79fc39ca44c5265eab133b7ec27/src/renderer/components/ft-button/ft-button.js#L30

The event is not passed through.

Additionally, you should use the doCreateWindow option on openInternalPath instead of handling it yourself. It already checks for electron.

[absidue]

Temporarily closing to hopefully fix the bugginess.

[github-actions[bot]]

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[github-actions[bot]]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions[bot]]

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[github-actions[bot]]

This PR was closed because it has been stalled for 14 days with no activity.