FreeTube icon indicating copy to clipboard operation
FreeTube copied to clipboard

Fix: Settings tooltips cut off at the bottom

Open ozrendev opened this issue 1 year ago • 5 comments

Fix: Settings tooltips cut off at the bottom

Pull Request Type

  • [x] Bugfix
  • [ ] Feature Implementation
  • [ ] Documentation
  • [ ] Other

Related issue

closes #6704

Description

Adds a larger margin to the bottom of setting sections when in mobile view

Testing

Resize the window while in Settings view and hover over an affected tooltip

Screenshots

Before 2025-02-02_17-06-28

After 2025-02-02_17-05-09

ozrendev avatar Feb 01 '25 04:02 ozrendev

When making UI changes it is always a good idea to provide before and after screenshots. Please re-add the parts of the template that you removed and add screenshots to it.

absidue avatar Feb 02 '25 18:02 absidue

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Feb 18 '25 01:02 github-actions[bot]

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Mar 11 '25 02:03 github-actions[bot]

I don't like this solution because it doesn't actually fix the core problem. It punts it down the road.

Also, it creates an issue on small displays where there is now a bunch of negative space below each settings section.

MarmadileManteater avatar Mar 18 '25 10:03 MarmadileManteater

I believe a better way to fix this would be to remove the overflow-*: hidden styles, but there are likely unexpected consequences to that. I feel like I've tried to address this issue before unsuccessfully.

MarmadileManteater avatar Mar 18 '25 10:03 MarmadileManteater

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Apr 02 '25 02:04 github-actions[bot]

This PR was closed because it has been stalled for 14 days with no activity.

github-actions[bot] avatar Apr 22 '25 02:04 github-actions[bot]