FreeTube icon indicating copy to clipboard operation
FreeTube copied to clipboard

[Bug]: In some languages, an extra scrollbar appears in the settings

Open MarkusGaugg opened this issue 1 year ago • 6 comments

Guidelines

  • [X] I have encountered this bug in the latest release of FreeTube.
  • [X] I have encountered this bug in the official downloads of FreeTube.
  • [X] I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
  • [X] I have searched the documentation for information that matches the description of the bug I want to file, without success.
  • [X] This issue contains only one bug.

Describe the bug

  1. Open Free Tube v0.22.0-nightly-5283 Beta (latest build)
  2. Set the language to German or Turkish
  3. Open settings and then enable "Sort Settings Selections (A-Z)"
  4. Now there's another scrollbar showing up here - marked in red
  5. Always reproducible - but only in certain languages like German or Turkish.

Ashampoo_Snap_Montag, 9  Dezember 2024_20h33m44s

Expected Behavior

This is how it should look.

Ashampoo_Snap_Montag, 9  Dezember 2024_20h35m50s

Issue Labels

visual bug

FreeTube Version

v0.22.0-nightly-5283 Beta

Operating System Version

Windows 11 - 23H2

Installation Method

.exe

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

No response

Additional Information

No response

Nightly Build

MarkusGaugg avatar Dec 09 '24 19:12 MarkusGaugg

Reproduced in v0.22.0-nightly-5283 Beta with the provided steps above.

This behavior occurs in about half of the languages, including Polish and Russian.

MarkusGaugg avatar Dec 09 '24 19:12 MarkusGaugg

Because of this bug, a different setting is underlined than the one I actually selected.

Here's a concrete example: I clicked and selected Distraction-Free Mode, and it's showing up, but "General" is still underlined.

Ashampoo_Snap_Montag, 9  Dezember 2024_21h9m54s

MarkusGaugg avatar Dec 09 '24 20:12 MarkusGaugg

The problem is long tooltip texts, while those texts do exist in other languages too, the alphabetical order of the settings with that toggle enabled, means that in those two languages the sections with the long tooltip texts at the bottom of them end up at the bottom of the list, so instead of overflowing into the other sections they overflow off the bottom of the list, causing the scrollbar to show up.

screenshot

absidue avatar Dec 09 '24 23:12 absidue

Hi everyone,

I’ve worked on fixing the issue. Instead of fully removing the overflow-x: hidden property in the CSS, I’ve decided to comment it out for now. This way, it can easily be reintroduced if needed later. I tested the fix locally and the scrollbar is no longer there, and everything looks good without introducing any horizontal scroll issues. Here’s the pull request for review: #6655. Let me know if there’s anything that needs adjusting!

Thanks!

sullivanlng avatar Jan 27 '25 16:01 sullivanlng