Sort by date on the history page

[jlvivero]

Sortbydate

Pull Request Type

• [ ] Bugfix
• [x] Feature Implementation
• [ ] Documentation
• [ ] Other

Related issue

Initial addition to #5595 (not sure it would be considered closed and we just make a new issue for future changes)

Description

Adds a sort by date ascending/descending toggle to the history page, this is a stopgap to adding a more fully fledged filter by setting, but I wanted to keep the changes small and incremental since design wise, some decisions have to be made and I'm not sure I'm the one that should make those decisions. (like other kinds of sorting/filtering in history page)

I also removed the second sorting it does when it does the search, since the array it uses is already sorted (in whichever order we choose), and the filter method I believe does a linear scan, it seemed unnecessary to sort twice, if we think it's necessary I can add it back and just add a condition to sort whichever way we need it to (But I don't think it's needed)

Screenshots

Testing

I tested by adding random videos to history, sorting it back and forth, then doing search and sorting back and forth as well

possibly with a huge history we'd like to view how the sorting performs... I don't have a huge history at the moment, so it's hard to tell. it's expected to a certain degree

Desktop

• OS: Pop!_OS
• OS Version: Pop!_OS 22.04 LTS
• FreeTube version: [email protected] dev

Additional context

I stuck to the simple toggle since I was only going to do the asc/desc sorting on this PR

[jlvivero]

o: it's been two weeks, hopefully this get reviewed soon so I can make any fixes necessary and/or start work on follow ups

[github-actions[bot]]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[jlvivero]

I made some changes based on feedback, I switched to ft-select, I prepared the store to prepare for more sort options, when more sort options are added, historyCacheSorted would be the place to change things

(instead of just an inline if a case and calls to different sorting would be necessary).

in the case of this sort, it's just reversing the list not actually sorting, if other sorts would be added, we would need to stop doing that and actually sort, so a decision would have to be made if it's worth adding more sorting possibilities that would obviously make sorting slower, particularly with people with huge histories.

[github-actions[bot]]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[jlvivero]

I might have messed up the way I solved the conflicts (let me know if you prefer a clean PR again :(, or if something else)

[absidue]

Please solve the conflicts properly, you seem to have pulled in all the commits from the development branch so now it is really difficult to tell what changes are yours and merging this PR will then reland all of the existing changes on the development branch a second time.

The two usual approaches are:

• git rebase development: That resets the starting point of your branch back to the current head of the development branch and recommits all of commits from this branch on top of it
• git merge development: This merges in the changes from the development branch in a single commit that git recognises as a merge commit so ignores when comparing the changes and when this branch is merged into development

As for how to fix what you have done here, I'm not sure.

[github-actions[bot]]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[jlvivero]

I reset to my latest commit, I used rebase, but I think I messed it up somehow, unsure how it ended that way you can see only my changes now, I'll try to fix the merge conflicts in a bit... HOPEFULLY not messing everything up again lol

had to reset HEAD --hard <my_last_commit>

then I did the rebase properly after that

EDIT. that should have fixed it, sorry about the random trouble... please review when you have the chance

[github-actions[bot]]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[efb4f5ff-1298-471a-8973-3d47447115dc]

lets emulate the view of the Playlists page, toggle left, dropdown right

change the icon like its done here

https://github.com/user-attachments/assets/8c5f6ade-5dc6-42e6-bcd2-d02b41c2071a

[github-actions[bot]]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions[bot]]

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[jlvivero]

Hi, I apologize I haven't had time to make the chances, just changed jobs, I'll try to get the changes done next weekend

[github-actions[bot]]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[jlvivero]

I updated the PR with the changes from the code review, sorry for the delays, holidays then changed jobs, so I had a pretty hectic couple of months

[efb4f5ff-1298-471a-8973-3d47447115dc]

Icon change requested in https://github.com/FreeTubeApp/FreeTube/pull/6214#issuecomment-2526194972 hasnt been implemented yet

[jlvivero]

Icon change requested in #6214 (comment) hasnt been implemented yet

I see I missed that one, I'll update it in a bit

[github-actions[bot]]

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[github-actions[bot]]

This PR was closed because it has been stalled for 14 days with no activity.