FreeTube icon indicating copy to clipboard operation
FreeTube copied to clipboard

Update ft-list-video.scss

Open An-anonymous-coder opened this issue 1 year ago • 3 comments

Fixed DeArrow thumbnails for Shorts

Pull Request Type

  • [X] Bugfix
  • [ ] Feature Implementation
  • [ ] Documentation
  • [ ] Other

Related issue

closes #5568

Description

The fix removes the preloaded 16 by 9 aspect ratio for thumbnails so that YouTube Shorts DeArrow thumbnails display in their intended aspect ratios.

Additional context

I have not tested it, because I don't know how.

An-anonymous-coder avatar Sep 06 '24 17:09 An-anonymous-coder

If you read the line you are editing it says 16/9 auto that means that it uses the 16:9 aspect ratio until the image is loaded (prevents the UI from jumping all over the place) and after that it uses the aspect ratio of the image, so this won't fix the problem that you are facing.

https://developer.mozilla.org/en-US/docs/Web/CSS/aspect-ratio#fallback_to_natural_aspect_ratio

absidue avatar Sep 08 '24 11:09 absidue

If you read the line you are editing it says 16/9 auto that means that it uses the 16:9 aspect ratio until the image is loaded (prevents the UI from jumping all over the place) and after that it uses the aspect ratio of the image, so this won't fix the problem that you are facing.

https://developer.mozilla.org/en-US/docs/Web/CSS/aspect-ratio#fallback_to_natural_aspect_ratio

Alright, then I am unaware of what is causing the issue. The images in the network tab are in the correct aspect ratio, but after looking for a while this is the only place I was able to find that references a 16 by 9 aspect ratio while loading.

An-anonymous-coder avatar Sep 09 '24 00:09 An-anonymous-coder

If you read the line you are editing it says 16/9 auto that means that it uses the 16:9 aspect ratio until the image is loaded (prevents the UI from jumping all over the place) and after that it uses the aspect ratio of the image, so this won't fix the problem that you are facing.

https://developer.mozilla.org/en-US/docs/Web/CSS/aspect-ratio#fallback_to_natural_aspect_ratio

Is it possible that the issue is caused by the original 16x9 thumbnails being loaded first, and then the DeArrow thumbnails? It means that the first thumbnails might hard set the aspect ratio before the other thumbnails are loaded.

An-anonymous-coder avatar Sep 12 '24 14:09 An-anonymous-coder

This PR is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Nov 10 '24 02:11 github-actions[bot]