FreeTube icon indicating copy to clipboard operation
FreeTube copied to clipboard

Fix app starting in fullscreen if a fullscreen video is closed

Open kommunarr opened this issue 1 year ago • 4 comments

Fix app starting in fullscreen if a fullscreen video is closed

Pull Request Type

  • [x] Bugfix

Related issue

closes #4534

Description

Co-created with @absidue. Fixes issue of the app starting in fullscreen if a video was closed in fullscreen.

Screenshots

Testing

  • Close a video with Ctrl/Cmd + Q while video is in fullscreen, then restart the app to see app not in fullscreen.
  • Regression: Ensure #2495 is still working correctly (app remains in fullscreen on creating new windows while in fullscreen).

Desktop

  • OS: OpenSUSE Tumbleweed
  • OS Version: 2023xxxx
  • FreeTube version: 0.19.1

Additional context

IIRC, fullscreen works differently in dev mode versus an actual build. Here are the builds, if that helps.

kommunarr avatar Feb 06 '24 20:02 kommunarr

After upcoming stable release, i will ask if people still experiencing this in https://github.com/FreeTubeApp/FreeTube/issues/3220

In both dev mode and with your provided build, im still getting fullscreened after quitting the video player in fullscreen using ctrl + w

idk if it matters but, dev mode is in Ubuntu and build installed on win10

This PR is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Mar 06 '24 01:03 github-actions[bot]

This PR is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Apr 04 '24 01:04 github-actions[bot]

If the current fix does not work, I'm really not quite sure what to do.

kommunarr avatar Apr 24 '24 14:04 kommunarr

Maybe co creator @absidue has an idea?