FreeTube icon indicating copy to clipboard operation
FreeTube copied to clipboard

[Feature Request]: Hardware video acceleration on Wayland

Open zestygrass opened this issue 1 year ago • 3 comments

Guidelines

  • [X] I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
  • [X] I have searched the documentation for information that matches the description of the feature request I want to file, without success.
  • [X] This issue contains only one feature request.

Problem Description

Hardware video acceleration implementation introduced in #4532 for Linux is currently X-org only.

Proposed Solution

Hardware video acceleration on Linux should support Wayland. In the near future, Wayland will be the default display server protocol for Linux. This change should make Freetube ready for when more DE's default to Wayland.

Distro's such as Fedora have approved Wayland only session for their KDE Plasma spin in Fedora 40. A similar issue was opened for Gnome in Fedora 40.

Alternatives Considered

N/A

Issue Labels

improvement to existing feature

Additional Information

No response

zestygrass avatar Jan 30 '24 04:01 zestygrass

Not sure this is something we can solve as Electron also seems to have some issues https://github.com/electron/electron/issues/36633

This will only be possible when updated to Electron 29 (Chromium 122), where this patch is merged.

Revival8697 avatar Jan 31 '24 21:01 Revival8697

I suppose this would be possible once electron has official support, now we wait for stable release of electron 29 later this month. Thanks for responding with appropriate information, it was helpful.

zestygrass avatar Feb 06 '24 04:02 zestygrass

hi all could you try the latest nightly build and report back if this behavior is fixed. The latest nightly build contains Electron version v29.x.x!

Tested it with nightly build 4044, hardware acceleration now works as intended on Wayland. Thank you so much.

I used the following flags if anyone else wants to try it. --enable-features=WaylandWindowDecorations --ozone-platform-hint=auto --enable-features=VaapiVideoDecodeLinuxGL --gpu-context=wayland

Screenshot_20240307_144443

System information:

Operating System: Fedora Linux 39
KDE Plasma Version: 5.27.10
KDE Frameworks Version: 5.115.0
Qt Version: 5.15.12
Kernel Version: 6.7.7-200.fc39.x86_64 (64-bit)
Graphics Platform: Wayland
Processors: 16 × 12th Gen Intel® Core™ i5-1240P
Memory: 31.1 GiB of RAM
Graphics Processor: Mesa Intel® Graphics
Manufacturer: Framework
Product Name: Laptop (12th Gen Intel Core)
System Version: A4

zestygrass avatar Mar 07 '24 14:03 zestygrass