FreeTubeApp
Improve search filter accessibility
Improve search filter accessibility
Pull Request Type
- [x] Bugfix
Related issue
resolves accessibility issue outlined here, and a handful of other accessibility issues with the filter icon
Description
- Adds title and
aria-pressedattribute to search filter icon, ensuring screenreaders will be aware of both what it is and when the filters are opened - Programmatically applies focus to the search filter popup when opened from the icon button
- Updates radio button styling to show the
--accent-active-colorcolor on hover and focus, resolving issue where currently focused radio button is impossible to visually determine - Updates filter button styling to appear visibly pressed when the filter popup is open
Screenshots
Testing
1. Confirm that the title "Search Filters" appears on hover of the filter icon.
2. Click the filter icon. Verify that the icon styling has changed.
3. Verify that the focus is now in the search filter popup.
4. Verify that the currently focused or hovered radio button changes color to the `--accent-active-color`.
5. Verify that the Search Filters icon appears has distinct styling when the search filters popup is open, and vice versa.
Desktop
- OS: OpenSUSE Tumbleweed
- OS Version: 2023xxxx
- FreeTube version: 0.19.0
This pull request has conflicts, please resolve those before we can evaluate the pull request.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Conflicts have been resolved. A maintainer will review the pull request shortly.
I noticed the removal of the WIP label. Does that mean this is ready for review
Does the PR description need updating to reflect latest changes? Just making sure we cover everything in testing and all the changes are listed
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
z-index issue in delete playlist prompt
Add video to playlist prompt > create playlist = error + add to playlist prompt invisible during create playlist (which is fine in function but feels strange)
Yeah, you're right about the idea to make a file with these z-indexes, I'm losing my mind
@absidue @MarmadileManteater @ChunkyProgrammer
My suggested ordering for reviewing my open PRs: this -> #4374 / #4970 -> #4949 -> #5013 / #5029
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.