FreeTube
FreeTube copied to clipboard
[Bug]: Browser extension dont work on macOS
Guidelines
- [X] I have encountered this bug in the latest release of FreeTube.
- [X] I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
- [X] I have searched the documentation for information that matches the description of the bug I want to file, without success.
- [X] This issue contains only one bug.
Describe the bug
bug was reported in https://github.com/FreeTubeApp/FreeTube/discussions/2747
I did check:
- https://github.com/SimonBrazell/privacy-redirect/blob/b31c5bf75a8e7dfef9ef5e55b8479bd553978578/src/pages/background/background.js#L277
- https://github.com/libredirect/libredirect/blob/4709a6667d71c0e57c0de8664d106be073a338db/src/assets/javascripts/services.js#L164
But when I paste rewritten url in safari for example, it prompts to open in FreeTube, but the video does not start. I see just the default home page.
freetube://https://youtu.be/y9TizOUqsuc
Main takes:
This seems to be a macOS specific bug that doesn't exist in the Linux or Windows builds of FreeTube (macOS implements URL schemes differently than Windows and Linux).
[...] the relevant lines in FreeTube's code are here: src/main/index.js#L738-L748 src/renderer/App.js#L501-L505
Pulled from IRC:
on Linux and Windows, the operating system does this when you use a URL scheme:
/path/to/freetube.exe freetube://https://youtu.be/y9TizOUqsuc
on macOS the operating system sends an event to the app which in electron isopen-url
, so some how our handling of it is not working properly
Expected Behavior
Extensions should work with FT
Issue Labels
content not loading
FreeTube Version
0.17.1
Operating System Version
macOS
Installation Method
.dmg
Primary API used
Local API
Last Known Working FreeTube Version (If Any)
No response
Additional Information
No response
Nightly Build
- [ ] I have encountered this bug in the latest nightly build.
This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.
@absidue is this even an issue on our end? When i looked through the repo of both extensions we have listed it seems like they both dont support Safari.
The person the reported the issue wasn't using a extension, they were trying the URLs directly for what I can gather from their comments.
This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.