[Bug]: Enable Theatre Mode by Default

[AudioDuplication]

Guidelines

• [X] I have encountered this bug in the latest release of FreeTube.
• [X] I have searched the issue tracker for a bug report that matches the one I want to file, without success.
• [X] I have searched the documentation for information that matches the description of the bug I want to file, without success.

Describe the bug

I interpret "Enable Theatre Mode by Default" to mean that, when I click a video in FreeTube and the player appears, it automatically enters Theater mode. However, it is my experience that this does not happen, eventhough I have set "Enable Theatre Mode by Default to ON"

Expected Behavior

Videos enter theater mode automatically as if I clicked "toggle theater mode" when I set "Enable theatre mode by default" to ON.

Issue Labels

feature stopped working

FreeTube Version

v0.16.0 Beta and v0.17.0-nightly-1850 Beta

Operating System Version

Windows 11 22H2

Installation Method

Portable

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

don't know

Additional Information

I use Windows 11

Nightly Build

• [X] I have encountered this bug in the latest nightly build.

[efb4f5ff-1298-471a-8973-3d47447115dc]

This works on my end on the latest nightly build. Can u provide a screenrecording of the bug. First show that setting is off -> go to video and check if it is in default mode. -> go to settings and Enable Theatre Mode by Default -> go to video

[AudioDuplication]

recording.webm

Here it is.

I also tested this on another of my computers, which has Windows 10 21H2. same problem.

My monitor is 1920x1080 with no display scaling on both computers. 1 has a Nvidia dedicated GPU with no integrated graphics, the other one only has integrated intel graphics.

[efb4f5ff-1298-471a-8973-3d47447115dc]

Is this still an issue for u in v0.17.1?

[PrestonN]

Just wanted to chime in and say that judging from your video, theatre mode is in fact enabled and working as expected. The logic for the video size is that we try to mostly cover up your screen without the video overstretching to the point where you'd have to scroll to view the video. This logic can behave differently depending on the aspect ratio of the video you're watching. You can observe how this logic works by resizing your window a bit, specifically vertically.

We don't add any black bars and oversize the video player outside of it's aspect ratio, so that might be why it looks different to you, but that is the largest we can make it with the restraints that we're wanting. If you're wanting it to take up more of the window, I would consider enabling Full window mode (The icon left of the quality selector in your video). Admittedly this feature cannot be enabled by default at the moment, but that might be more of what you're wanting in this situation.

[AudioDuplication]

Oh it appears I made the mistake of thinking that "Full Window" was theatermode.

I would appreciate it if "automatic window mode" would be a option in the settings.