FreeTube icon indicating copy to clipboard operation
FreeTube copied to clipboard
verified publisher icon FreeTubeApp

Don't save progress if video genre is music

Open ai25 opened this issue 3 years ago • 3 comments

Don't save progress if video genre is music closes

Important note We may remove your pull request if you do not use this provided PR template correctly.

Pull Request Type Please select what type of pull request this is:

  • [x] Bugfix
  • [ ] Feature Implementation

Related issue #1522

Description There is no need to save watch progress for music. This makes it so that if the video genre is music, it sets the watch progress to 0 instead of the db value.

Screenshots (if appropriate) Please add before and after screenshots if there is a visible change.

Testing (for code that is not small enough to be easily understandable) Has this pull request been tested? Please describe shortly how you tested it and whether there are any ramifications remaining. I tested it for a few days with no issues on Invidious API, but I am unable to test on Local API since it doesn't work for me. I don't think there should be any issues, but if someone else can test it I would appreciate it. Desktop (please complete the following information):

  • OS: [Manjaro]
  • OS Version: [5.10.117-1]
  • FreeTube version: [0.17.0]

Additional context Add any other context about the problem here.

ai25 avatar Jul 21 '22 02:07 ai25

Tested local API as well and everything seems fine.

ai25 avatar Jul 22 '22 23:07 ai25

@absidue Thanks for the review. I've updated it with settings now.

ai25 avatar Jul 31 '22 11:07 ai25

Could you please fix that small typo? The rest of the code looks good.

done, thanks

ai25 avatar Jul 31 '22 11:07 ai25

This PR is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Oct 20 '22 02:10 github-actions[bot]

@vr10t ?

PikachuEXE avatar Oct 20 '22 02:10 PikachuEXE

This PR is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Nov 18 '22 02:11 github-actions[bot]

This PR was closed because it has been stalled for 14 days with no activity.

github-actions[bot] avatar Dec 03 '22 01:12 github-actions[bot]

@PikachuEXE @absidue would either of you like to take this PR over? If not I could do it

ChunkyProgrammer avatar Dec 03 '22 02:12 ChunkyProgrammer

@ChunkyProgrammer Just do it~ There are only a few changes left

PikachuEXE avatar Dec 03 '22 02:12 PikachuEXE

How to find videos with genre "music" ._.

PikachuEXE avatar Dec 05 '22 02:12 PikachuEXE

How to find videos with genre "music" ._.

Here is an example video i found: https://www.youtube.com/watch?v=rgaTLrZGlk0

I think i might have opened up an issue for adding these details on the watch page in freetube but here it is in newpipe: image

ChunkyProgrammer avatar Dec 05 '22 03:12 ChunkyProgrammer

If https://www.youtube.com/watch?v=rgaTLrZGlk0 is also "music" then this feature shouldn't be included? Coz it's not actually music video but "video about music"

PikachuEXE avatar Dec 05 '22 05:12 PikachuEXE

If https://www.youtube.com/watch?v=rgaTLrZGlk0 is also "music" then this feature shouldn't be included?

Good point: https://github.com/FreeTubeApp/FreeTube/issues/1522#issuecomment-881109476

Maybe we should close this PR?

ChunkyProgrammer avatar Dec 12 '22 03:12 ChunkyProgrammer

I will close this until we have a way to clearly differentiate music videos (but not videos about music) from others

PikachuEXE avatar Dec 12 '22 03:12 PikachuEXE