FreeTubeApp
[Bug]: right click on video player doesnt say Hide Video Statistics
Guidelines
- [X] I have encountered this bug in the latest release of FreeTube.
- [X] I have searched the issue tracker for a bug report that matches the one I want to file, without success.
- [X] I have searched the documentation for information that matches the description of the bug I want to file, without success.
Describe the bug
- Go to any video
- Right click on player
- Click on Show Video Statistics
- Right click on player again
- Says 'Show Video Statistics' instead of Hide Video Statistics
Expected Behavior
Should say Hide Video Statistics when Video Statistics are enabled.
Issue Labels
inconsistent behavior, text/string issue
FreeTube Version
https://github.com/FreeTubeApp/FreeTube/commit/b1b5467dd318500c45ce7bf80acef333e0416c39
Operating System Version
Win10 21H2
Installation Method (If applicable)
No response
Last Known Working FreeTube Version (If Any)
No response
Primary API used
No response
Additional Information
No response
Nightly Build
- [x] I have encountered this bug in the latest nightly build.
This will likely be an annoying conditional to actually make, should we just change the label to a non-action like "Video statistics". That way it will be an implied toggle?
Most context menus don't use "conditional" keywords so if you look at most browsers for example:
Inspect (Q) is not Open Inspect Tool and doesn't then change to Close Inspect Tool Select all doesn't change to Deselect all Youtube's Stats for nerds doesn't change to Close Stats for nerds
So simply I say we change the label to "Video statistics" in line with this convention
Changing the string to say "Show / Hide Video Statistics" would probably be the simplest solution to this.
This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}