FreeTube icon indicating copy to clipboard operation
FreeTube copied to clipboard

[Bug]: Disable horizontal scrollbar and make the UI fit to screen in portrait mode

Open bigbiggie opened this issue 2 years ago • 30 comments

Guidelines

Describe the bug

On most videos the UI looks good, but when there is a large link or a large word without spaces (for example a bitcoin address) in the description, the UI of FreeTube will create horizontal scrollbars and it is not possible to watch the video anymore. See pictures 20220501_20h40m58s_grim 20220501_20h41m40s_grim 20220501_20h41m59s_grim .

Expected Behavior

The video player should always fit into the window.

Issue Labels

visual bug

FreeTube Version

v0.16.0 Beta

Operating System Version

Arch Linux Arm

Installation Method (If applicable)

Flathub

Last Known Working FreeTube Version (If Any)

No response

Primary API used

No response

Additional Information

No response

Nightly Build

bigbiggie avatar May 01 '22 19:05 bigbiggie

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Oct 12 '22 02:10 github-actions[bot]

what's the aspect ratio of your device?

ceeb9 avatar Oct 28 '22 05:10 ceeb9

@MarmadileManteater im not able test but was this fixed by ur latest PR?

what's the aspect ratio of your device?

It's a pinephone (5.95'', 1440x720)

@MarmadileManteater im not able test but was this fixed by ur latest PR?

It's mostly fixed. The horizontal scrollbar still appears sometimes, when reading comments (i.e. when showing replies of a comment). It doesn't seem to happen on all videos, no idea why. On the video in the second picture (v=zrProK5R7ms), this bug can be reproduced by showing the comments, viewing the replies of the pinned comment, scrolling down, and then clicking on show more replies.

bigbiggie avatar Oct 31 '22 15:10 bigbiggie

I've noticed that long channel names with no spaces in them tend to cause the page to overflow. They can be anywhere on the page. Sometimes, they are in the related videos section, but they aren't always. I could imagine that comment replies are probably more prone to this issue since they provide less space for the channel name to appear than top level comments.

A fix for this might be to change the word-wrap styling on channel names to break-word.

MarmadileManteater avatar Oct 31 '22 15:10 MarmadileManteater

Also, buttons sometimes cause the page to overflow because they don't word wrap. This isn't a problem if the locale is set to English. image

MarmadileManteater avatar Nov 01 '22 08:11 MarmadileManteater

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Nov 30 '22 02:11 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Dec 29 '22 01:12 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jan 27 '23 01:01 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Feb 28 '23 02:02 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Mar 29 '23 01:03 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Apr 27 '23 01:04 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar May 26 '23 01:05 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jun 24 '23 02:06 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jul 23 '23 01:07 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Aug 21 '23 01:08 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Sep 19 '23 01:09 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Oct 18 '23 01:10 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Nov 16 '23 01:11 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Dec 15 '23 01:12 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jan 18 '24 01:01 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Feb 25 '24 01:02 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Mar 25 '24 01:03 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Apr 23 '24 01:04 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar May 22 '24 01:05 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jun 21 '24 01:06 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jul 20 '24 01:07 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Aug 18 '24 01:08 github-actions[bot]