Search failure causes filters to be ignored

[Winterhuman]

Guidelines

• [X] I have encountered this bug in the latest release of FreeTube.
• [X] I have searched the issue tracker for a bug report that matches the one I want to file, without success.

Describe the bug

1. Search "libp2p" or "ipfs" with the search filter set to "Upload Date"
2. Observe Error: Client network socket disconnected before secure TLS connection was established, either by searching twice or letting it fail by itself, and that the results aren't ordered by upload date as they should be.

Expected Behavior

Search filters should always correctly filter videos.

Issue Labels

feature stopped working

FreeTube Version

v0.16.0 Beta

Operating System Version

Arch Linux

Installation Method (If applicable)

Flathub

Last Known Working FreeTube Version (If Any)

Unknown

Primary API used

Local API

Additional Information

I have a screenshot, but GitHub says "Something went really wrong..." and won't let me upload it.

Nightly Build

• [ ] I have encountered this bug in the latest nightly build.

[efb4f5ff-1298-471a-8973-3d47447115dc]

cant reproduce on the latest nightly build

[efb4f5ff-1298-471a-8973-3d47447115dc]

could u provide other examples?

[Winterhuman]

Managed to do a filtered search without encountering https://github.com/FreeTubeApp/FreeTube/issues/1939 (doing the search again after searching another term temporarily fixes it), and the ordering for "libp2p" is correct now; ~~interrupting the search by hitting enter while the search is loading is the cause~~.

EDIT: I was able to reproduce this without the double-search, I searched "ipfs" and the search failed by itself, the results were not ordered by upload date as they should of been; any error during search causes filter failure.

[Winterhuman]

This would technically be solved if https://github.com/FreeTubeApp/FreeTube/issues/1939 was fixed, but, ideally searching the same term twice while the first search is happening shouldn't cause it to be interrupted.

[Winterhuman]

Looks like the search changes have fixed this issue; I can't replicate this issue anymore in v0.17, yay!

Closing issue

[Winterhuman]

Wait no sorry, I was thinking of https://github.com/FreeTubeApp/FreeTube/issues/1939. The random errors have been fixed so trying to see if errors cause filters to be ignored is going to be difficult

[efb4f5ff-1298-471a-8973-3d47447115dc]

@Winterhuman is this still an issue ur facing?

[Winterhuman]

I can't reproduce it technically, but that's only because I can't figure out how to trigger a search failure; the search is too reliable now (not exactly a bad issue though). Without the failures, I can't verify if they cause search filters to be ignored still

[efb4f5ff-1298-471a-8973-3d47447115dc]

Because it isn't reproduceable I'm going to close it. Feel free to comment when u can reproduce it.