FreeTube icon indicating copy to clipboard operation
FreeTube copied to clipboard

[Bug]: Can't create a string longer than xxx characters

Open TMS-Namespace opened this issue 3 years ago • 25 comments

Guidelines

Describe the bug

It happens wherever I start FreeTube, pressing on OK on the error message (see below screenshot), it continues to work fine, but all contents of my favorites (play list) is empty. I think this happened because I added too many items to the play list, because for a long time everything was working fine, but lately this started to happen suddenly, and no app update took place within this period.

image

Expected Behavior

No error should happen, and the play list should contain the items I chosen.

Issue Labels

causes crash

FreeTube Version

v0.16.0 Beta

Operating System Version

Win10, 21H1, 19043.1586

Installation Method (If applicable)

Portable

Last Known Working FreeTube Version (If Any)

No response

Primary API used

Local API

Additional Information

No response

Nightly Build

TMS-Namespace avatar Apr 08 '22 08:04 TMS-Namespace

Hey there! If it's alright with you, could you please send me your playlists file? You can use this article to know where it's located. Sending it to me at [email protected] or through Matrix would be best. I can take a look at it and see what needs to be done in order for it to be read properly.

PrestonN avatar Apr 08 '22 14:04 PrestonN

@PrestonN Hi, sorry I prefer to not send it for privacy concerns.

However, I am a programmer also, although in a different field/technologies from the one FreeTube uses, so maybe you can tell me what to look on, so I can check my self.

A made quick look on the playlists.db file, that happened to be of unrealistically large size (547MB!), and that as I understand, is JSON-like formatted. I noticed that the same root element is being repeated many times (360 times exactly), along with all its contents, this seemed to be incorrect...

I opened it in VSCode, removed the repeated lines, the file size become about 1.5Mb, and now FreeTube runs fine, and my old favorites are all in place.

Hence, you need to recheck your playlist saving logic, something causes it to go into a loop of repeating same contents, particularly 360 times.

TMS-Namespace avatar Apr 08 '22 14:04 TMS-Namespace

It's all good. I understand the concerns.

The playlist logically will likely be overhauled once I'm done with full user created playlists, so I'll take an extra look at that logic and make sure nothing is duplicating on accident.

Our DB can potentially show multiple entries when the app is running and would be as intended, but if they persist when the app is closed then that would obviously be an issue that needs looked at.

This admittedly might not get looked at right away and I'll save it for when I'm back to working on full playlists.

If you'd like to look a bit deeper yourself, the majority of the logic you're looking for will likely come from these three files. The logic for starting the workflow will be here. Feel free to let me know if you have any questions.

PrestonN avatar Apr 09 '22 19:04 PrestonN

Had the same happening to me.

Playlist was at nearly 700MB. I restored last nights backup (at 300MB). ..

Then starred my favs from subs again, closed freetube. Reopened, now it's back at 2.3MB and works fine.

Will report back if it appears again. Really keen on knowing what triggers this.

tracure1337 avatar Apr 10 '22 12:04 tracure1337

It appears whenever a change to a playlist is appends the file instead of overwriting it, every time I make a change to the playlist the size of the file increases by 1 line.

GlowingUmbreon avatar May 26 '22 21:05 GlowingUmbreon

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Oct 13 '22 02:10 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Nov 11 '22 02:11 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Dec 10 '22 01:12 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jan 30 '23 01:01 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Feb 28 '23 02:02 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Mar 29 '23 01:03 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Apr 27 '23 01:04 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar May 26 '23 01:05 github-actions[bot]

@efb4f5ff-1298-471a-8973-3d47447115dc

I have a feeling that you should the exempt-issue-labels feature to stop the spam from this action. Having to re-open this ticket every month probably negates the benefit from having this feature.

https://github.com/actions/stale#exempt-issue-labels

exempt-issue-labels
Comma separated list of labels that can be assigned to issues to exclude them from being marked as stale (e.g: question,bug)

If unset (or an empty string), this option will not alter the stale workflow.

Default value: unset

GlowingUmbreon avatar May 27 '23 19:05 GlowingUmbreon

@GlowingUmbreon we are using this workflow only on bug reports, feature requests are exempted. Every month when a bug report gets stale we will evaluate if it is still unresolved. We have caught 100+ issues this way that could be closed and are still catching issues that are resolved but still open. This is how we use it to keep our issue tracker clean. I understand that it could be annoying for u to get an notification about this every month but this is a way of working is very efficient for us.

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jun 27 '23 02:06 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jul 26 '23 01:07 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Aug 24 '23 01:08 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Sep 22 '23 01:09 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Oct 22 '23 01:10 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Nov 20 '23 01:11 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Dec 20 '23 01:12 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jan 18 '24 01:01 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Feb 25 '24 01:02 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Mar 25 '24 01:03 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Apr 23 '24 01:04 github-actions[bot]

Does this still happen in the latest version of FT?