Channel community page

[GilgusMaximus]

---

Channel community page

Pull Request Type Please select what type of pull request this is:

• [ ] Bugfix
• [x] Feature Implementation

Description This patch adds the community page tab to all channels. Items that can be displayed:

• Videos
• Images
• Text
• Polls
• Playlists

Screenshots (if appropriate)

Testing (for code that is not small enough to be easily understandable) Has this pull request been tested? Has been tested extensively for all kinds of channels.

Desktop (please complete the following information):

• OS: Windows
• OS Version: 10
• FreeTube version: v13.2

Additional context Still todo as discussed: Include playlist css into standard playlist css and check whether playlist is displayed in list or standalone mode

[peepo5]

Looks good. If it still looks the same as the picture provided, upper padding would look nice.

[peepo5]

I will wait till jason's recommendations are responded to before I can verify code.

[peepo5]

Would like to see more progress on this, as it looks like a very good feature that would be very useful for FT. We will have to wait for @GilgusMaximus to respond.

[GilgusMaximus]

Sorry for not answering anything on here. Thought this might be merged before i start into my exchange semesters, but it didn't happen anymore. So atm i am keeping off of any development here as I have lots of stuff to do and a lot of activities finally happining again. But some short notice in the regards from @jasonhenriquez :

• Yes it was clear if other things get merged in, then this PR will not be able to hold up with the new standards and changes.
• It is intended that comments do not load as this would be a second step. This feature is so large that splitting it in two seems not only the maintainability friendlier option but also easier to test as there are so many new design elements in here.
• The polls could not be fetched to my knowledge as the results are only displayed once you vote yourself I believe.

I'll check whether i can safely open up the branch on my fork for you guys to edit it, otherwise feel free to clone the branch and bring it up to your own pr and merge it correctly as I won't be able to do any changes in the future (prob. till summer)

[ChunkyProgrammer]

Will need to redirect community links to community tab when #1455 is merged

[peepo5]

Is there more padding now?

[ChunkyProgrammer]

Is there more padding now?

I don't think so

[ChunkyProgrammer]

Would like to see https://github.com/FreeTubeApp/yt-channel-info/pull/48 merged and a new version of yt-channel-info released before this PR gets merged

[ChunkyProgrammer]

"Fetch more results" on channel community page is too large (tested on H3 Podcast channel, no posts seemed to load?)

[efb4f5ff-1298-471a-8973-3d47447115dc]

Would like to see FreeTubeApp/yt-channel-info#48 merged and a new version of yt-channel-info released before this PR gets merged

@ChunkyProgrammer The PR has been merged. So now the only thing that needs to be done before we can review this is releasing a new version of yt-channel-info right?

[ChunkyProgrammer]

Would like to see FreeTubeApp/yt-channel-info#48 merged and a new version of yt-channel-info released before this PR gets merged

@ChunkyProgrammer The PR has been merged. So now the only thing that needs to be done before we can review this is releasing a new version of yt-channel-info right?

Correct

[efb4f5ff-1298-471a-8973-3d47447115dc]

@ChunkyProgrammer yt-channel-info has been updated. Can i start reviewing this?

[ChunkyProgrammer]

@ChunkyProgrammer yt-channel-info has been updated. Can i start reviewing this?

#2126 would need to be merged first

[efb4f5ff-1298-471a-8973-3d47447115dc]

So there is nothing blocking this anymore for me to start reviewing right?

[ChunkyProgrammer]

It looks like a new type of post was added and community isn't working for every channel because of it.

Example of a currently working one:

So there is nothing blocking this anymore for me to start reviewing right?

https://github.com/FreeTubeApp/yt-channel-info/pull/67 will need to be merged and a new yt-channel-info version should be released. (Some community pages won't load until this happens)

[efb4f5ff-1298-471a-8973-3d47447115dc]

FreeTubeApp/yt-channel-info#67 has been merged

[peepo5]

Hey guys, a lot of content creators are now using the community tab. It would be nice if this could be merged if there is nothing blocking it. Thanks.

[efb4f5ff-1298-471a-8973-3d47447115dc]

@ChunkyProgrammer the only thing that is missing is the comment section but i dont know if we need to implement that

[ChunkyProgrammer]

• Hide Community page if the user doesn't have one https://www.youtube.com/user/artfol2
• show message 'This channel hasn't posted yet' when community page is enabled but there a no posts yet https://www.youtube.com/c/monicageuze/community
• Community page is disabled on this channel so it would be nice to hide it https://www.youtube.com/c/FirewallsDontStopDragons/featured

I think hiding the community tab is out of scope for this PR as About, Video and Playlist tabs still show for channels that don't have videos or playlists. So, I think this should be handled by a future PR.

I'll add a "Channel hasn't posted yet" message when I get the chance

[ChunkyProgrammer]

@GilgusMaximus i'm not sure when I'll get around to updating this PR. Feel free to take over again as you seem to be active again if you'd like.

[GilgusMaximus]

I can check it out at some point again. I'll start over from the module tho, as i want to make sure that the base still works. No clue whether the package still gets all data properly.

Edit: just checked the module, seems to work still fine. I just followed the discussion through:

• Hiding the community page should not be necessary as a base implementation. As @ChunkyProgrammer mentioned
• The message that nothing was posted yet should be a good enough solution for the moment

Otherwise, besides the rebase, is something else missing? I remember there was something about layouting, which was the original reason the pr didn't finish back last year that @PrestonN mentioned. But from my perspective it still looks fine, if it also works with different screen sizes.

I can check whether i can merge resolve tomorrow (edit again: that was easy, already done) and then add the text message for empty pages. This could be a major feature for 0.18 then. And would be good if this goes in early then, as we then can test it during the whole development cycle already.

[GilgusMaximus]

Okay, so I checked a bit and updated where it was necessary. What I now found is that when you make the window small enough, the text starts to break out:

Idk how relevant that is at some points, but here we have the problem that a lot of text is also displayed. Am not really that happy with it atm but have to really look into what i can do to prevent that, as that was something i struggled with last time as well i believe.

But clearance for the images, they load in the built version. I think it is just a development environment error

[GilgusMaximus]

Okay so i had to do a base restructure of how we wrap the posts. Now it is consistent with the other pages and makes the displaying of the 'no posts yet' message easy. Now basically restyling the posts to fit better is left and then this can be tested extensively and shipped for v0.18.0

[GilgusMaximus]

Okay final touches done, so this can now basically be tested extensively, so it will be ready for the next rc.

Only thing that I know is a bug at the moment, is the missing of the author link at videos or so, but this is fixed in https://github.com/FreeTubeApp/yt-channel-info/pull/84 already. Just needs to get merged.

[PikachuEXE]

I can test this until 0.17 is released Since my testing is basically having changes to be tested included in my own custom builds and use them everyday

[GilgusMaximus]

Okay question, does the community page work for you if you click 'more'. Like i can see the extra posts being parsed and printed in the console, but the page does not reload to include them

[efb4f5ff-1298-471a-8973-3d47447115dc]

Okay question, does the community page work for you if you click 'more'. Like i can see the extra posts being parsed and printed in the console, but the page does not reload to include them

@GilgusMaximus Just double checked and it doesnt show older posts when u click on load more

[GilgusMaximus]

Okay thanks for the update. I already tried to investigate a bit, but atm am a bit stuck on where the issue occurs. Because before the small rewrite, it did not happen. It might take a bit until I figure that out

[ChunkyProgrammer]

It appears Invidious has an api endpoint at /api/v1/channels/CHANNEL ID/community that will return json used for a community page. Not sure if this should be implemented in this PR or an upcoming PR. It also appears that this endpoint isn't documented in the invidious api so we would likely need to create an issue on their docs repo asking them to document the api

[github-actions[bot]]

This pull request has conflicts, please resolve those before we can evaluate the pull request.