opcua-modeler icon indicating copy to clipboard operation
opcua-modeler copied to clipboard

[0.3.1] Copy-Paste Node does not modify Namespace id of browename and nodeid

Open Stasik0 opened this issue 8 years ago • 4 comments

Copy-paste should be of paste-environment and adjust Browsename accoringly Also id generation should be consideren

Stasik0 avatar Nov 17 '16 11:11 Stasik0

Can you explain further you explanantion? when copying a new nodeid is created and the original browse name is kept. how do you think it should behave?

On Thu, 17 Nov 2016 at 12:37 Sten Grüner [email protected] wrote:

Copy-paste should be of paste-environment and adjust Browsename acoringly

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/FreeOpcUa/opcua-modeler/issues/31, or mute the thread https://github.com/notifications/unsubscribe-auth/ACcfztksvHfY1VUzy68BhrOx9dDg9Hhkks5q_Dx2gaJpZM4K1Mt0 .

oroulet avatar Nov 17 '16 12:11 oroulet

There is a Browsename in format "nsid:String" and there is a nodeid as a struct with nsid and so on.

If I paste a node where a context is clear e.g. an attribute form node in NS0 and paste it as a child of type in NSX, I'd like that browsename is changed from "0:bla" to "X:bla" and the NS id in the new nodeid is change accordingly. Furthermore, a popup would be good to ask me to enter or generate a unique nodid in new namespace.

What do you think?

Stasik0 avatar Nov 17 '16 13:11 Stasik0

Showing a dialog is a good idea. We can ask for namespace. But asking for node IDs seems difficult, there may be many nodes created...

On Thu, Nov 17, 2016, 14:14 Sten Grüner [email protected] wrote:

There is a Browsename in format "nsid:String" and there is a nodeid as a struct with nsid and so on.

If I paste a node where a context is clear e.g. an attribute form node in NS0 and paste it as a child of type in NSX, I'd like that browsename is changed from "0:bla" to "X:bla" and the NS id in the new nodeid is change accordingly. Furthermore, a popup would be good to ask me to enter or generate a unique nodid in new namespace.

What do you think?

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/FreeOpcUa/opcua-modeler/issues/31#issuecomment-261243450, or mute the thread https://github.com/notifications/unsubscribe-auth/ACcfztqLPQbq7MPEfLPJL-b2NqdaFK-Gks5q_FNIgaJpZM4K1Mt0 .

oroulet avatar Nov 17 '16 13:11 oroulet

To be honest I never use copy paste when I'm using modeler, but it seems like we would only need to choose a namespace for pasting. Then we can use the existing "new node" convention, which is like this:

  1. Auto node id uses counter specific for each address space; this counter auto increments
  2. Create own node id by typeing, and you need to type the "ns=x" yourself; if you make an int or string node id all child node ids will follow the same convention

In a previous PR I tired to make ns=x automatically match the selected namespace, but @oroulet said that user should type it. I don't really understand why, but that's how it is for now.

zerox1212 avatar Nov 17 '16 16:11 zerox1212