FreeCAD icon indicating copy to clipboard operation
FreeCAD copied to clipboard

[DO NOT MERGE] [Surface]: BlendCurve Feature

Open Matteo-Grellier opened this issue 3 years ago • 2 comments

Related forum thread : https://forum.freecadweb.org/viewtopic.php?f=10&t=70187 this pr implements the blendpoint and blendcurve c++ classes and the blendcurve and python binding. Reviews and comments are welcome as we are c++ beginners. Thanks.

Thank you for creating a pull request to contribute to FreeCAD! To ease integration, we ask you to conform to the following items. Pull requests which don't satisfy all the items below might be rejected. If you are in doubt with any of the items below, don't hesitate to ask for help in the FreeCAD forum!

  • [x] Your pull request is confined strictly to a single module. That is, all the files changed by your pull request are either in App, Base, Gui or one of the Mod subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next ones
  • [x] In case your pull request does more than just fixing small bugs, make sure you discussed your ideas with other developers on the FreeCAD forum
  • [x] Your branch is rebased on latest master git pull --rebase upstream master
  • [x] All FreeCAD unit tests are confirmed to pass by running ./bin/FreeCAD --run-test 0
  • [x] All commit messages are well-written ex: Fixes typo in Draft Move command text
  • [x] Your pull request is well written and has a good description, and its title starts with the module name, ex: Draft: Fixed typos
  • [x] Commit messages include issue #<id> or fixes #<id> where <id> is the issue ID number from our Issues database in case a particular commit solves or is related to an existing issue. Ex: Draft: fix typos - fixes #4805

And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.20 Changelog Forum Thread.


Matteo-Grellier avatar Aug 08 '22 14:08 Matteo-Grellier

pipeline status for feature branch PR_7339. Pipeline 607455096 was triggered at 813f599. All CI branches and pipelines.

berndhahnebach avatar Aug 08 '22 14:08 berndhahnebach

pipeline status for feature branch PR_7339. Pipeline 607476532 was triggered at ac48978. All CI branches and pipelines.

berndhahnebach avatar Aug 08 '22 15:08 berndhahnebach

pipeline status for feature branch PR_7339. Pipeline 618200658 was triggered at b10b8d2. All CI branches and pipelines.

berndhahnebach avatar Aug 19 '22 20:08 berndhahnebach

Snap package testers can test this PR per instructions below:

  # Note: not all distros require 'sudo'
  $ sudo snap install --channel=edge/pr-53 freecad

  # If you already have the freecad snap installed
  $ sudo snap refresh --channel=edge/pr-53 freecad 

  # Experimental: Parallel install (see https://github.com/FreeCAD/FreeCAD-snap/blob/master/docs/index.md#parallel-installs)
  $ sudo snap set system experimental.parallel-instances=true
  $ sudo snap install --channel=edge/pr-53 freecad_pr53
  $ freecad_pr53 # Run it

  # To switch back to preferred snap (swap out 'edge' for 'stable' if necessary)
  $ snap refresh freecad --channel=edge freecad

luzpaz avatar Aug 19 '22 21:08 luzpaz

Rebaised didn't go well. I need to fix this tomorrow.

Matteo-Grellier avatar Aug 22 '22 15:08 Matteo-Grellier

Yea, looks like you included unrelated commits. been there done that, i can empathize :roll_eyes:

luzpaz avatar Aug 22 '22 15:08 luzpaz

pipeline status for feature branch PR_7339. Pipeline 619888180 was triggered at 5e80fc2. All CI branches and pipelines.

berndhahnebach avatar Aug 22 '22 19:08 berndhahnebach

I fixed the rebase issue and now the pr is ready to be merged.

Matteo-Grellier avatar Aug 23 '22 09:08 Matteo-Grellier

Thanks!
Running CI and triggering Snap build

Edit: new build will post to https://github.com/FreeCAD/FreeCAD-snap/pull/53 when it's generated.

luzpaz avatar Aug 23 '22 13:08 luzpaz

Several fixes made with eb1f30d327

wwmayer avatar Aug 23 '22 15:08 wwmayer