FreeCAD icon indicating copy to clipboard operation
FreeCAD copied to clipboard

Update libe57format

Open mosfet80 opened this issue 1 year ago • 5 comments

. updated libe57format from version 2.2.1 to 3.2.0

changelog:

https://github.com/asmaloney/libE57Format/blob/master/CHANGELOG.md

mosfet80 avatar Oct 25 '24 10:10 mosfet80

@mosfet80 can you resolve the conflicts?

maxwxyz avatar Nov 25 '24 17:11 maxwxyz

@mosfet80 ping for conflicts

maxwxyz avatar Nov 30 '24 20:11 maxwxyz

@mosfet80 ping

maxwxyz avatar Dec 06 '24 06:12 maxwxyz

bump

maxwxyz avatar Dec 08 '24 19:12 maxwxyz

What are all these changes from FLOAT_MAX to FLT_MAX? Those don't seem related to the libe57format update.

chennes avatar Dec 08 '24 20:12 chennes

@maxwxyz this should be set to draft until we get feedback. So that it does not come up on every meeting.

PaddleStroke avatar Dec 13 '24 12:12 PaddleStroke

@PaddleStroke we exclude https://github.com/FreeCAD/FreeCAD/labels/Status%3A%20Stale

maxwxyz avatar Dec 13 '24 12:12 maxwxyz

@maxwxyz ah ok, the URL in https://www.freecad.org/events.php needs to be updated then to reflect this.

PaddleStroke avatar Dec 13 '24 12:12 PaddleStroke

@mosfet80 ping for conflicts

maxwxyz avatar Jan 08 '25 07:01 maxwxyz

@oursland is going to try this with git subtree instead so we can compare approaches.

chennes avatar Jan 20 '25 17:01 chennes

should this PR be closed then?

maxwxyz avatar Feb 03 '25 14:02 maxwxyz

Closing in favor of #19276

chennes avatar Feb 10 '25 17:02 chennes