FreeCAD
Partial fix Freeze
Fix #12829
Ping @maxwxyz
-
[x] Frozen state does not persist on save and opening a file. If I freeze an object, alter it and save it, the alteration is not displayed. When reopening, the modified object is visible and the object is not frozen anymore (recompute at opening). The last modification before closing is now irreversible and lost, although the object was frozen and shouln't be altered. a 'freezed' object now prevent the document to be saved.
-
[x] If a PartDesign body is frozen, all nested features can be changed and alter the frozen body. linked objects are 'freezed' / 'unfreezed' when the state changes
-
[x] A frozen body can be chamfered in the PartWB. After that it cannot be unfrozen again. Part_Chamfer create a new ('unfreezed') object, the nested Body is still 'freezed' and 'unfreezable'
-
[x] A frozen sketch can be activated but is displayed empty in the Sketcher WB
-
[x] The visibility eye icon does not change its state when clicked but the visibillity in the 3D view is toggled (reproduced with a nested sketch in a PartDesign Pad feature) Also reproduceable with nested object which are frozen inside of a group (e.g. walls in an arch group)
-
[ ] Frozen command does not register with undo/redo It acts on the object state not on a property. The object is not modified. Not sure it's needed
-
[ ] If you use a part of a frozen object to create a new feature it throws an error (tried to pad a face of the frozen feature: Index out of bound) Can not reproduce
-
[ ] If you undo and redo and the body is frozen, all redone features are now outside of the body and cannot be moved inside of the body
-
[ ] You can edit frozen features (e.g. draft objects). They wont change but the edit is permanent. On unfreezing, the edit will be applied.
-
[x] Transform commands move the object, even when frozen. When using Draft WB move, they don't move
-
[x] Placement command moves the frozen object.
-
[ ] Non-reversable operations could be applied to frozen objects (e.g. smooth a frozen mesh). If this is done by accident it is not noticed, as there is no feedback to the user. If the mesh is later unfrozen, the smoothed, decimated shape is visible.
-
[x] The freeze icon is not optimal. It covers the entire icon of the feature, body or object. It is not clear if you want to unfreeze something if this is a body or part container, a spreadsheet or PartDesign features. Maybe it can also be combined with the eye icon as the appearance of the object is frozen Fixed
-
[ ] Could it be placed in the context menu section at the bottom, where "Mark to recompute" and "Recompute" is located, as I understand it's related to that?
-
[ ] Could it be renamed? I did not figure out what this is doing and had to look through the PRs. Proposals: Exclude from recompute, Lock current state,
-
[ ] Could it have a checkbox like "Active body" (at the top of the context menu), like: [ x ] Locked to see the current state in the context menu
@FlachyJoe another approach which was brought up by @obelisk79 was to remove the additional snowflake icon and instead desaturate the original icon of the object and color it slightly blue/icy. Maybe the label text of the object could be greyed out as well.
@maxwxyz I've currently no idea how to do this but if no one is in a hurry, I'll learn.
@FlachyJoe did you change something else with the context menu? It renders always on the top edge of the screen, not on mouse location. Only in PD (own context menu) its at the cursor location.
@FlachyJoe also here the heads up for the upcoming feature freeze. As there are a lot of open points, are you considering this a post 1.0 PR?
@maxwxyz this is a bug fix not concerned by feature freeze but should be done before release, right?
@FlachyJoe Will some of those fixes make it 1.0? It would be good to have the Freeze option available in Part Design, for instance.
I'm not available to end this before release date. The current state with partial fix can be merged.
I'm not available to end this before release date. The current state with partial fix can be merged.
Sure, no need to fix all the issues at once. If this PR is good to go and fixes some of the issues, please undraft it so that it can be merged.
Can the commit subject and body be re-edited. They are very generic, don't mention which ticket it addresses. This is important for folks writing the Release Notes and documentation. TIA
