FreeCAD-macros icon indicating copy to clipboard operation
FreeCAD-macros copied to clipboard

Add StitchCut macro for sheet metal stitch cuts

Open JohnHyslop opened this issue 2 months ago • 4 comments

This PR adds the StitchCut macro by John Hyslop. It creates evenly spaced stitch cuts in sketches for hand-folded sheet metal parts. Source repository: https://github.com/JohnHyslop/MyFreeCADMacros

JohnHyslop avatar Dec 13 '25 07:12 JohnHyslop

Is there any benefit to adding this to the SheetMetal Workbench ?

luzpaz avatar Dec 15 '25 04:12 luzpaz

Could you please add the relevant metadata for the Addon Manager as described here? Otherwise only the name of the macro will display.

chennes avatar Dec 15 '25 04:12 chennes

Is there any benefit to adding this to the SheetMetal Workbench ?

Yes, I think it would be useful in the SheetMetal Workbench, as it directly supports hand-folding and creating precise cuts in sheet metal. It could also have broader applications, such as creating evenly spaced cuts for square or rectangular knockouts in panels. If the macro proves popular, it might make sense to include it officially, but it works well as a standalone macro for now. Shaise’s workbench already has a perforation tab for folds and rectangular perforations, but most laser-cut parts I’ve worked with only require single line cuts. Perhaps an option could be added in that tab to incorporate this functionality as well.

JohnHyslop avatar Dec 15 '25 05:12 JohnHyslop

Could you please add the relevant metadata for the Addon Manager as described here? Otherwise only the name of the macro will display.

Done, I hope I've filled this out correctly.

JohnHyslop avatar Dec 15 '25 05:12 JohnHyslop

Once I figure out how to place the macro on GitHub as SheetMetal/StitchCut.FCMacro, I'll commit all the changes.

JohnHyslop avatar Jan 30 '26 22:01 JohnHyslop

Once I figure out how to place the macro on GitHub as SheetMetal/StitchCut.FCMacro, I'll commit all the changes.

You just make the modification in your repo, commit and push to the same branch. The PR is automatically updated.

galou avatar Jan 31 '26 05:01 galou

Hi Galou,

I’ve made the requested changes and updated the SheetMetal/StitchCut macro, including the renaming, the icon, and the updated features. The wiki page has also been created with the relevant details, though I am currently experiencing an issue where the page displays as blank when opened. I’m looking into it, but everything is saved on my end.

Thanks for your help and suggestions!

Cheers, John Hyslop

JohnHyslop avatar Feb 01 '26 02:02 JohnHyslop

Hi @galou,

I hope you're doing well!

I’ve made all the changes based on your suggestions, including the renaming, icon addition, and updated features. The necessary adjustments have been made, and everything else looks good on my end.

When you have a moment, could you please take a final look at the changes? If everything looks good to you, I’d be happy to proceed with the merge.

I really appreciate your time and feedback, and I’m looking forward to hearing your thoughts.

Thanks again for all your help!

Best regards, John Hyslop

JohnHyslop avatar Feb 02 '26 04:02 JohnHyslop

If everything looks good to you

Hi @JohnHyslop, I can have missed something but the last changes I see are from Dec. 2025. To update the PR, just push commits to the same branch on your fork.

galou avatar Feb 02 '26 06:02 galou

Hi @galou,

I hope you're doing well! I’m sorry if this question seems unclear, but I’m a bit confused about some of the recent changes. I committed my updates, but I noticed that Roy changed SheetMetal/StitchCut to SheetMetalStitchCut. Also, I’ve found that these first two links appear to be different from each other.

Could you kindly help me understand what I should do here? Should I rename the Macro and SVG files to follow this new naming convention, and is it necessary to delete the SheetMetal folder?

Just to add, Luzpaz had helped me with the TechDraw SVG symbols a while ago, as I’m still getting familiar with how everything works.

Here are the links I’m referencing:

https://github.com/JohnHyslop/FreeCAD-macros/tree/master/StitchCut

https://github.com/JohnHyslop/MyFreeCADMacros

https://wiki.freecad.org/index.php?title=Macro_SheetMetalStitchCut&oldid=1746628

Thank you so much for your help, and I appreciate your guidance!

Best regards, John Hyslop

JohnHyslop avatar Feb 03 '26 07:02 JohnHyslop

Your repo MyFreeCADMacros is unrelated with our repo (i.e. it's not a fork, i.e. the history of both repos do not start with the same commit hash). You should commit the changes to your fork of our repo. A solution to integrate the changes now is to generate patches with git patch from MyFreeCADMacros and apply them with git apply to your fork of our repo. I can also do it but you're the best placed to know which commits to include.

Moreover, the changes by Roy are on the Wiki, which is also unrelated with our repo.

It'd would be actually better to rename the macro SheetMetal/SheetMetalStitchCut.FCMacro. In the worse case, I can do it myself after merge. The directory SheetMetal is to organize macros within this repository. The prefix SheetMetal in the file name is to organize the macros in the list of available macros in FreeCAD.

Directories cannot be indexed in git, it's up to you if you delete the directory or not since it's only local. If you meant files within this directory, this is another matter.

galou avatar Feb 03 '26 07:02 galou