FreeCAD-macros icon indicating copy to clipboard operation
FreeCAD-macros copied to clipboard

Invalid license for SketcherOffset.FCMacro

Open chennes opened this issue 1 year ago • 3 comments

This macro contains a __license__ entry, but does not specify a valid license there. The line should be removed, or a valid SPDX license identifier put in place. https://github.com/FreeCAD/FreeCAD-macros/blob/25fcaf70eb49c7ba68d1b7958404ae104e15430c/Sketcher/SketcherOffset.FCMacro#L14

chennes avatar Feb 10 '24 15:02 chennes

@edi271 can you please react to this?

Maybe we could remove the macro since offset is now implemented natively in Sketcher?

galou avatar Feb 27 '24 13:02 galou

The Offset tool implemented in the Sketcher is working in an other way, that means, it returns in some situations other results than the macro. If you think best, please remove the macro.

edi271 avatar Mar 01 '24 13:03 edi271

I don't have anything against letting the macro here if it behaves differently. Moreover, it's a well-written macro that can serve as a reference for many things.

What about the license? I can make the change myself if you name one.

galou avatar Mar 01 '24 21:03 galou