FreeCAD-addons icon indicating copy to clipboard operation
FreeCAD-addons copied to clipboard

[ + ] Typing Extensions

Open EdgarJRobles opened this issue 6 months ago • 8 comments

Required for improve code reading .

EdgarJRobles avatar Aug 06 '25 03:08 EdgarJRobles

@EdgarJRobles

Please use the resolved package handle ( typing-extensions -> Check the PyPI page )

PhoneDroid avatar Aug 06 '25 14:08 PhoneDroid

@EdgarJRobles thanks for the PR -- in addition to @PhoneDroid's comment, please keep the package list in alphabetical order. Thanks!

chennes avatar Aug 06 '25 15:08 chennes

Thanks for clarify guys. in code typing extensions must be type as import typing_extesion but to install from pip it must type as typing-extesion then package.xml should contain <depend optional="False" type="automatic">typing-extensions</depend>

then typing_extension is not required

EdgarJRobles avatar Aug 07 '25 02:08 EdgarJRobles

reopen because https://github.com/EdgarJRobles/quetzal/commit/06ce9d2d14fece2ca1eec71391cf023c37714a2b didn't work

i changed <depend optional="False" type="automatic">typing_extensions</depend> to <depend optional="False" type="automatic">typing-extensions</depend> in package.xml still no auto install typing-extensions

is there something missing?

EdgarJRobles avatar Aug 08 '25 01:08 EdgarJRobles

Your PR here is still valid, and required, it just needs a bit of cleanup. You DO need to add typing-extensions to the list of Python packages that the Addon Manager is allowed to install, but you should add it to the list following the PEP 503 Normalization (e.g. "typing-extensions", not "typing_extensions"), and it should be added in alphabetical order.

chennes avatar Aug 08 '25 02:08 chennes

the module was added 2 weeks ago image still not get it

EdgarJRobles avatar Aug 08 '25 04:08 EdgarJRobles

I'll try to find a machine that doesn't have typing-extensions installed at the system level and give it a test run. Keep in mind that unless you are using the development branch of the Addon Manager, you will have to either update your addon, or uninstall and reinstall it, for the addon manager to pick up the new dependency.

chennes avatar Aug 24 '25 16:08 chennes

🤖 Constraints Bot: regenerated the constraints files and added a commit with the changes

github-actions[bot] avatar Nov 03 '25 03:11 github-actions[bot]