FreeCAD-Homepage icon indicating copy to clipboard operation
FreeCAD-Homepage copied to clipboard

Forum: emoji size out of proportion in default theme (also when not signed-in)

Open luzpaz opened this issue 5 years ago • 19 comments

Issue: https://forum.freecadweb.org/viewtopic.php?t=32722 image

Console warning:

This page uses the non standard property “zoom”. Consider using calc() in the relevant property values, or using “transform” along with “transform-origin: 0 0”. viewtopic.php
Source map error: Error: request failed with status 404
Resource URL: https://forum.freecadweb.org/styles/freecad/theme/stylesheet.css?assets_version=30
Source Map URL: stylesheet.css.map

This is the expected behavior: switch over to the elegance theme (i'm using the Firefox 'Dark Reader' addon hence the dark theme) image

luzpaz avatar Dec 21 '20 09:12 luzpaz

@yorikvanhavre the class selectors are .emoji .smilies

luzpaz avatar Feb 08 '21 12:02 luzpaz

/cc @yorikvanhavre @kkremitzki

luzpaz avatar Feb 14 '21 14:02 luzpaz

This is still an issue, reopening
case in point: https://forum.freecadweb.org/viewtopic.php?f=8&t=55645&p=479829#p479829 image

luzpaz avatar Feb 19 '21 13:02 luzpaz

Maybe the _common.scss files are being overwritten ?

luzpaz avatar Feb 19 '21 13:02 luzpaz

Ok, it just needed to be pushed to the server. This issue is fixed!

luzpaz avatar Feb 27 '21 11:02 luzpaz

stylesheet doesn't apply to those not logged in.

  1. log out of forum
  2. browse https://forum.freecadweb.org/viewtopic.php?f=3&t=56319#p484442

luzpaz avatar Mar 06 '21 22:03 luzpaz

image

luzpaz avatar Apr 01 '21 00:04 luzpaz

logged in and emojis are still rendering larger than normal.

image

ipatch avatar Apr 13 '21 18:04 ipatch

seriously?

luzpaz avatar Apr 13 '21 18:04 luzpaz

seriously?

as a heart attack. 💔

ipatch avatar Apr 13 '21 19:04 ipatch

it's not related to failing to load the sourcempa is it.

image

ipatch avatar Apr 13 '21 19:04 ipatch

Can you make sure by logging in and hard refreshing pages that have the 'newer' emojis on them? Also would you mind experimenting with different forum themes (changing them in the settings)?

luzpaz avatar Apr 14 '21 12:04 luzpaz

just tried with vivaldi, chrome, and firefox, logged in, not logged in still the same. is there a github repo that hosts the phpbb code for the forum? i might be able to take a look at the source and see if i can find anything out of the norm.

image

ipatch avatar Apr 21 '21 17:04 ipatch

@yorikvanhavre can you weigh in?

luzpaz avatar Apr 21 '21 17:04 luzpaz

i forgot i posted this thread in the forum a while back,

https://forum.freecadweb.org/viewtopic.php?f=8&t=52663

so i guess all the styling for the forum and wiki are contained within this git repo. 👍

ipatch avatar Apr 21 '21 21:04 ipatch

Indeed. I have merge permissions on this repo...so feel free to submit PRs and I'll test them.

luzpaz avatar Apr 22 '21 01:04 luzpaz

that emoji class you added to the stylesheet isn't being added to the stylesheet when i visit the freecad forum, as evident when viewing the assets for the forum in this image below,

image

if you do a search for .inner:after in the sources tab of the browser tools you'll see the .emoji class is never added to the stylesheet.

as evident from viewing the commit you made,

https://github.com/FreeCAD/FreeCAD-Homepage/blob/master/forum/styles/freecad/theme/_common.scss#L1936

the emoji class .emoji should appear within the stylesheet but does not. it also appears the styles are using sass ie. .scss which i believe need to be precompiled at some point before they can be served up to a normal (chrome,firefox) web browser before they well be rendered.

so if i had to take a shot in the dark maybe the assets haven't been compiled since you pushed your changes to this repo.

i don't know how this whole infrastructure works, in hwo the actual server picks the code from this repo and then renders it, so i can't really comment on that. but i hope this helps in further understanding of what is going on.

ipatch avatar Apr 22 '21 19:04 ipatch

@kkremitzki you have experience with sass?

luzpaz avatar May 15 '21 13:05 luzpaz

Afraid not. This broke again because there were breaking changes to the theme our FreeCAD and FreeCAD-Dark themes are based on... it would be good to have something a little more maintainable.

kkremitzki avatar May 18 '21 02:05 kkremitzki