ColoradoRLA icon indicating copy to clipboard operation
ColoradoRLA copied to clipboard

Election date off by one in County Audit Report

Open sfsinger19103 opened this issue 8 years ago • 5 comments

(per RLA Tool Feedback #1_tool version2)

CDOS reports date of 8/21 in report even though 8/22 was entered as date of election.

sfsinger19103 avatar Sep 21 '17 15:09 sfsinger19103

This is not a server issue (alone). The server stores the instant that the client sends it, and renders it in the server's time zone in reports. So we have two choices:

  • agree between the client and server that dates that represent only dates are always stored in GMT, and always rendered in GMT
  • have the client send an instant that will have the right date in the server's time zone

I'm OK with either, but need to know which one. @ranweiler?

dmzimmerman avatar Sep 21 '17 15:09 dmzimmerman

Should be fixed by the changes in #752, but hasn't been tested yet.

dmzimmerman avatar Sep 21 '17 23:09 dmzimmerman

Sorry @dmzimmerman, I hadn't seen your @ earlier. For date forms, what we do is the 2nd option: we parse a bare date string in the local timezone, so the serialized form is an instant (in UTC time) such that it is the desired date where the date was selected (i.e. local to the user).

ranweiler avatar Sep 21 '17 23:09 ranweiler

Interesting. Since I was rendering it in the local time zone of the server, I'm confused, then, as to what the problem was. It would be interesting to know if it is fixed now.

dmzimmerman avatar Sep 21 '17 23:09 dmzimmerman

I believe this was fixed in ca02a683a768d476699157b17e1845ae9c0edc0a. We should confirm.

ranweiler avatar Sep 25 '17 20:09 ranweiler