ColoradoRLA icon indicating copy to clipboard operation
ColoradoRLA copied to clipboard

Resolve IndicateHandCount/SelectContestsForAudit endpoints

Open dmzimmerman opened this issue 8 years ago • 4 comments

Right now, these two endpoints have identical code: it takes an array of ContestToAudit objects as the request, and updates the DoS dashboard with them. This allows it to be used to:

  1. select contests to audit
  2. select contests for hand count
  3. deselect contests for either of those things

Internally in the dashboard, all contests under audit or handcount are stored with the same kind of record (ContestToAudit), which identifies whether it is under audit or hand count. It seems like it's overcomplicating things to have two endpoints that do the same thing, but we might want them to actually do validation on their input (so that one only takes contests to audit, and the other only takes contests to hand count; if we do that, though, it's not clear how mistakes in input from the DoS side can be corrected - and in fact, to allow that to happen, we probably need a state machine change anyway).

dmzimmerman avatar Aug 13 '17 08:08 dmzimmerman

I believe these will remain separate for phase 2; moving to phase 3.

dmzimmerman avatar Aug 24 '17 01:08 dmzimmerman

For now, these are still separate. It doesn't hurt anything, but I'd still like to change it eventually.

dmzimmerman avatar Aug 31 '17 07:08 dmzimmerman

For now, are hiding the hand count option in the DOS contest selection screen.

ranweiler avatar Sep 01 '17 10:09 ranweiler

Moving this to someday. See also: https://github.com/FreeAndFair/ColoradoRLA/issues/742

ranweiler avatar Sep 20 '17 16:09 ranweiler