ungit icon indicating copy to clipboard operation
ungit copied to clipboard

[Feature Request] Branch search box

Open ZimGil opened this issue 5 years ago • 12 comments

It would be nice to have a search box at the branches list so you can easily find the branch you're looking for in a big project where it can get really annoying to find it by scrolling on 2 axis.

ZimGil avatar May 02 '19 14:05 ZimGil

Screen Shot 2019-05-02 at 19 14 57

Like some of the features, it is not documented so few people know but there is a drop down of all branches and tags like above. And you can checkout by click the row, or delete by clicking x.

It is not exactly a "search" but would this be suffice?

jung-kim avatar May 03 '19 02:05 jung-kim

I knew about this but I work on an enormous repo and hard to find sometimes.

I guess it would be nice to have a search box on the top of this list that will filter out whichever branch isn't falling under the search string.

ZimGil avatar May 08 '19 08:05 ZimGil

I can add ref search box within the branch drop down. I think that would be sufficient right?

jung-kim avatar May 15 '19 16:05 jung-kim

Sounds good! 👍

ZimGil avatar May 16 '19 11:05 ZimGil

@jung-kim Can I give it a try?

ZimGil avatar May 16 '19 11:05 ZimGil

Oh shucks, I will try to deliver soon but it's not quite ready yet... But will let you know when it is ready

jung-kim avatar May 17 '19 02:05 jung-kim

I meant to create it :)

ZimGil avatar May 17 '19 06:05 ZimGil

Oh I see, absolutely!

There is already a similar search box if you are looking for an example, backend code and frontend code. But it is at node level and scope is only the refs in that node. (I may hide this by default and enable this node level ref search to be enabled only when a node has more than N number of refs as it is bit silly in most cases).

Also, I must say code on this is bit sloppy and if you have a cleaner way I would be all for it

jung-kim avatar May 17 '19 16:05 jung-kim

I will be going on very long vacation soon so I might be very limited in availability but feel free to ask me any questions about how to build and etc.

jung-kim avatar May 17 '19 16:05 jung-kim

Meanwhile you're on vacation I can help too and start the review

ylecuyer avatar May 17 '19 17:05 ylecuyer

Sorry but I had to close this PR as I'm too busy right now to fix it

ZimGil avatar Jun 30 '19 11:06 ZimGil

Is anyone working on this? Would love to give it a shot. @jung-kim

JackNeus avatar Mar 28 '20 14:03 JackNeus