Frederick Zhang

Results 190 comments of Frederick Zhang

The issue with #551 is that if you write something like `level123: (level, levelKey, log, { label, labelColorized, colors })` in TypeScript, it still transpiles while it shouldn't. label and...

Hi, new to this project, just wondering if supporting lombok in `InvalidLogMessageFormat` falls into the scope of this issue? For example, pmd reports 'missing arguments' on ```java public class Book...

I can replace `@UpdateDateColumn` with `@Column({ type: 'timestamp', name: 'updated_at', precision: 6, default: () => 'CURRENT_TIMESTAMP(6)', onUpdate: 'CURRENT_TIMESTAMP(6)' })`, but `FooRepository.save(foo, { reload: true })` no longer does a SELECT...

Turned out from() needed to handle UlidMonotonic as well: https://github.com/Frederick888/playground/commit/54cdaf0c49d6d809f778e1b52e1c106b0d14b350

> can you provide some more context about the end-to-end workflow here? I believe this relates to triangular workflows where there are 2 remotes, one configured for push and one...

@williammartin > * Only if `push.default` is empty or `upstream` then we use the `merge` config entry Actually here it uses `MergeRef` only if `push.default` is `upstream`, not when it's...

> I'm trying to imagine whether this could have broken any other `push.default` configurations: > > * `nothing` Such users are probably of those who always use `git push origin...

@williammartin Done 😄 (Gonna have to head off soon but let me know if you have other concerns.)

> Under what circumstances could there be a remote branch that has a PR open from it, but `@{push}` doesn't resolve when `push.default = current`? > > The only case...

> Yeh right, so when `push.default = current` the second commit is only relevant if the remote branch hasn't been fetched. Or the user hasn't pushed. > That seems like...