bench-runner icon indicating copy to clipboard operation
bench-runner copied to clipboard

More specific instructions needed

Open correaa opened this issue 2 years ago • 2 comments

Hi, I am running Ubuntu 21.10 and cloned the repository.

After doing

git clone https://github.com/FredTingaud/bench-runner.git
cd bench-runner
./quick-bench

I get:

docker: Got permission denied while trying to connect to the Docker daemon socket at unix:///var/run/docker.sock: Post "http://%2Fvar%2Frun%2Fdocker.sock/v1.24/containers/create": dial unix /var/run/docker.sock: connect: permission denied.
See 'docker run --help'.

I found elsewhere (https://www.digitalocean.com/community/questions/how-to-fix-docker-got-permission-denied-while-trying-to-connect-to-the-docker-daemon-socket) that I need to do this first:

sudo chmod 666 /var/run/docker.sock

Maybe you can consider adding that to the instructions, or at least say a few keywords about the Docker socket.

After that you can also mention that you need to point the browser to localhost:4000, or whatever is in the output of the ./quickbench command.

It would be also nice to give some instructions on how to install third-party (apt) libraries although that is another question. (I followed the ssh method in https://github.com/FredTingaud/bench-runner/issues/2, but QB still couldn't find the header file).

correaa avatar Jun 12 '22 18:06 correaa

Hi @correaa,

setting the permissions to 666 on /var/run/docker.sock is NOT something that you should do. Doing so will give the permission for any user to become root on your machine without any password since the docker daemon always run as the root user.

You are getting this error message because you are trying to run docker as a non-root user. If you want to be able to use docker without root permissions you should add the user to the group "docker".

Here's the step from the official documentation : https://docs.docker.com/engine/install/linux-postinstall/.

felix642 avatar Jun 20 '22 17:06 felix642

A sentence pointing at this issue could help in the "instructions" section.

correaa avatar Jun 20 '22 17:06 correaa