Maui.FreakyEffects icon indicating copy to clipboard operation
Maui.FreakyEffects copied to clipboard

Possible workaround to #11

Open Jon2G opened this issue 1 year ago • 3 comments

Possible workaround to #11 https://github.com/dotnet/maui/issues/19576#issuecomment-2131584486 Also review InitFreakyEffects on MauiProgram sample it fails due to "An item with the same key has already been added. Key: Maui.FreakyEffects.TouchEffects.TouchRoutingEffect'" Recording 2024-05-25 231953

Jon2G avatar May 26 '24 05:05 Jon2G

I just checked this, it might fix the issue with the background colour but still won't fix, the text colour part, now the thing is that the text colour can't be set to transparent or to some colour by default as there is no default here if you know what i mean

FreakyAli avatar May 26 '24 05:05 FreakyAli

Yeah i was thinking about that, but text color should never possibly be null Let me take a look

Jon2G avatar May 26 '24 05:05 Jon2G

Hi, can you take a look a the new changes at discussion at https://github.com/dotnet/maui/issues/22914 :)

Jon2G avatar Oct 01 '24 07:10 Jon2G

Walkthrough

The pull request updates the solution and project configurations to support .NET 9. Changes include an update of the Visual Studio version and project GUIDs in the solution, new target frameworks and package reference enhancements in project files, and modifications in several animation classes by adding the [AcceptEmptyServiceProvider] attribute and refining property implementations. Additional updates cover UI styling adjustments, platform-specific modifications, and the suppression of a duplicate key initialization in the sample app.

Changes

File(s) Change Summary
Maui.FreakyEffects/...sln Updated Visual Studio version (16 → 17), changed project GUIDs, and added a deployment configuration for the Samples project.
Maui.FreakyEffects/…/Maui.FreakyEffects.csproj Added .NET 9 target frameworks (including Android, iOS, Mac Catalyst, and Windows), introduced SkipValidateMauiImplicitPackageReferences, and updated package references (e.g. using $(MauiVersion) and upgraded SkiaSharp).
Maui.FreakyEffects/Samples/…Samples.csproj Upgraded target frameworks from net8.0 to net9.0 and updated package references (CommunityToolkit.Maui, Microsoft.Maui.Controls/Compatibility, FreakyControls, SkiaSharp).
Maui.FreakyEffects/…/Shared/Skeleton/*Animation*.cs Added [AcceptEmptyServiceProvider] attribute across animation classes; updated BaseAnimation’s Parameter property to use a nullable backing field with a default value; and added a parameterless constructor in FadeAnimation.
Maui.FreakyEffects/…/Shared/Skeleton/SkeletonEffect.cs Changed BindableProperty types from View to VisualElement and refined methods for state management, including null checks and a switch-based handling in OnIsBusyChanged.
Maui.FreakyEffects/…/SkiaScene/SKScene.cs Modified the Concat method call to pass the Matrix parameter as in Matrix instead of ref Matrix for read-only usage.
Maui.FreakyEffects/…/Shared/TouchEffects/PlatformTouchEffect.android.cs Specified Android.Graphics.Color for the _color field, updated SetEffectColor to use ToPlatform(), and applied conditional compilation in the disposal logic.
Maui.FreakyEffects/Samples/MauiProgram.cs Commented out the call to effects.InitFreakyEffects() to prevent a duplicate key exception related to TouchRoutingEffect.
Maui.FreakyEffects/Samples/SkeletonEffect/SkeletonEffectView.{xaml, xaml.cs} Moved the XML namespace declaration, added a new Setter for the Label’s BackgroundColor and a TextColor update in XAML, with only formatting changes in the code-behind.

Sequence Diagram(s)

sequenceDiagram
    participant Consumer as Animation Consumer
    participant Animation as FadeAnimation
    participant Service as Optional Service Provider

    Consumer->>Animation: new FadeAnimation()
    Animation->>Animation: Check for [AcceptEmptyServiceProvider] attribute
    Animation->>Animation: Initialize Parameter (backing field defaults to 0.6 if null)
    alt Service provider provided
        Animation->>Service: Resolve dependencies
    else No service provider
        Animation->>Animation: Proceed with default initialization
    end
    Animation-->>Consumer: Return animation instance

Poem

Hop, hop, I’m a coding hare,
Skipping through GUIDs and frameworks with flair.
Animations bloom with a gentle tweak,
Attributes added—oh, what a peek!
Nibbling bugs along my way,
I celebrate these changes in a joyful display 🐇✨.

[!TIP]

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b50c84e5939dd65617f4fd88e350a7d5f9062a90 and ded8f0318b9f048f5454bf22f8818a964c9cd982.

📒 Files selected for processing (1)
  • Maui.FreakyEffects/Samples/Samples.csproj (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • Maui.FreakyEffects/Samples/Samples.csproj

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Apr 14 '25 03:04 coderabbitai[bot]