Frederik Hudák

Not sure, it's part of syntax check though (likely only on newer releases, but this is not something which needs to be release-specific) 

"We're too ashamed to add a longtext, just do it"

This one raises the runtime dump `CONVT_NO_NUMBER` ```abap TRY. DATA(garbage_as_number) = `abc`. DATA(number) = 0. IF number = garbage_as_number. BREAK-POINT. ENDIF. IF garbage_as_number = number. BREAK-POINT. ENDIF. CATCH cx_sy_conversion_no_number INTO...

I think this should be part of global configuration as it could be used by multiple checks or find references ```json object_name_literals: { [ { "type": "tabname", object_type: "TABL" },...

there is also `IF before LOOP` ```abap IF lines( itab ) > 0. LOOP AT itab. ENDLOOP. ENDIF. ``` variants: - check instead of if - initial check instead of...

```abap REPORT zfh3. TYPES: t_shorter_char TYPE c LENGTH 10. TYPES: t_longer_char TYPE c LENGTH 20. TYPES: t_string TYPE string. DATA: short TYPE t_shorter_char. DATA: long TYPE t_longer_char. DATA: string TYPE...

`strict_table_index_type`

one more variant with `check` ```abap CHECK e071_data IS NOT INITIAL. SELECT * FROM e070 FOR ALL ENTRIES IN @e071_data WHERE trkorr = @e071_data-trkorr AND ( trfunction = 'K' OR...

Constant structures are valid, but usage on interfaces is not recommended in the guidelines https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-enumeration-classes-to-constants-interfaces My suggestion is for the rule to also work if you specify the constant structure...

I don't mind the collection pattern but what we use currently for domain values is the separate classes so i went with that first. In this pattern we sometimes have:...