Fraser Waters

Results 278 comments of Fraser Waters
trafficstars

We should probably just see if we can fix the chdir, it's grim the engine does that and it blocks a lot of other improvments.

> LSPs can't follow the type definition They should be able to in _most_ cases. We do make use of a few python dynamic features which the typing system does...

We should be able to give a better message here like "unexpected input of type method for property ExampleType.example_field". Just means threading through some context information into serializeProperty/Properties.

> If that isn't load bearing, I'm happy to remove it. Pretty sure it isn't. In practice we only ever make the element inside the Computed value the empty string,...

> Should we add marshal/unmarshal to protobuf.Struct/Value, or just round trip through the old PropertyValue system for now? Catching up with Slack it sounds like the plan is to roundtrip...

> If not, we can add them later. Let's defer for now, but not for too long. Get this in, then have a good look at how y'all want to...

`depends_on` is supposed to be an array of Resource objects and get_topic returns just a data object. There is a type annotation on that, but it might make sense for...

> I think the Resource constructor should proactively check that the values of check the types of the inputs to ensure they are Resources in order to generate a meaningful...

> Anything keeping us from merging this? I haven't checked this actually works...