Franz Busch
Franz Busch
This is an interesting issue. We recently came across `gmtime_r` in swift-certificates as well and @Lukasa implemented a Swift only version of this that performs way better and most importantly...
@compnerd I am trying to get our implementation over to foundation. Just figuring out the legal stuff here since we did initially port the musl libc functions into Swift.
This PR should fix this: https://github.com/apple/swift-foundation/pull/179
I agree 1) seems reasonable and if a user puts a `description` or `unit` label into the metric then we should just use that for OTEL.
Can you update the branch to resolve the conflicts. I can help with getting it merged.
> I would anticipate there are some concerns about exposing the logger handler's internal state so directly? Having simple functions for getting/setting logger metadata provides a simple, easier-to-secure abstraction. I...
@swift-server-bot test this please
Thanks for filling this! This is definitely something that we would take a patch for and parallelise the removal similar to how we did for copying in https://github.com/apple/swift-nio/pull/2806.
This package, like many other packages, doesn't support building in library evolution mode. The package is intended to be consumed from source. If you want to use this package in...
Was outbound half closure enabled on the channel?